Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iroha2-connector): fix flaky tests to solve #2370 and #2373 #2381

Merged
merged 1 commit into from
May 4, 2023
Merged

fix(iroha2-connector): fix flaky tests to solve #2370 and #2373 #2381

merged 1 commit into from
May 4, 2023

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Apr 7, 2023

  • Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: #2370
Closes: #2373

petermetz
petermetz approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM just please try to make the commit subject a little more unique. If neither of the file paths of the test cases fit in the subject because they are too long for the linter then I would at least include the two issue numbers in the subject as well just so that it's easy to distinguish this commit from the other commits in the future that will do the same thing (flaky tests are something that always comes up even if we disappear all of them at once new race conditions get added all the time)

@outSH outSH force-pushed the iroha2_flaky_test_fix_pr branch from ce04851 to f433ad9 Compare April 11, 2023 09:44
@outSH outSH changed the title fix(iroha2-connector): fix flaky tests fix(iroha2-connector): fix flaky tests to solve #2370 #2373 Apr 11, 2023
@outSH outSH changed the title fix(iroha2-connector): fix flaky tests to solve #2370 #2373 fix(iroha2-connector): fix flaky tests to solve #2370 and #2373 Apr 11, 2023
@outSH
Copy link
Contributor Author

outSH commented Apr 11, 2023

@outSH LGTM just please try to make the commit subject a little more unique. If neither of the file paths of the test cases fit in the subject because they are too long for the linter then I would at least include the two issue numbers in the subject as well just so that it's easy to distinguish this commit from the other commits in the future that will do the same thing (flaky tests are something that always comes up even if we disappear all of them at once new race conditions get added all the time)

@petermetz Sure thing, done :)

@outSH outSH requested a review from petermetz April 11, 2023 09:46
@ryjones ryjones force-pushed the iroha2_flaky_test_fix_pr branch from f433ad9 to d774951 Compare April 11, 2023 13:41
@petermetz petermetz force-pushed the iroha2_flaky_test_fix_pr branch from d774951 to 4e0a574 Compare April 11, 2023 21:17
petermetz
petermetz previously requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy change request so that we don't accidentally merge this before the other orgs approval.

izuru0
izuru0 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepnRES sandeepnRES force-pushed the iroha2_flaky_test_fix_pr branch from 4e0a574 to 9aa8c83 Compare April 26, 2023 06:36
sandeepnRES
sandeepnRES approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@sandeepnRES sandeepnRES left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sandeepnRES sandeepnRES dismissed petermetz’s stale review April 26, 2023 06:38

Dismissing dummy change request as now we have atleast 2 orgs approval

@outSH @petermetz
fix(iroha2-connector): fix flaky tests to solve hyperledger-cacti#2370 …
0e16601 
…and hyperledger-cacti#2373

- Use waitForCommit for all transactions used in test suites to prevent spurious CI test failures.

Closes: hyperledger-cacti#2370
Closes: hyperledger-cacti#2373

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@petermetz petermetz force-pushed the iroha2_flaky_test_fix_pr branch from 9aa8c83 to 0e16601 Compare May 3, 2023 23:59
@petermetz petermetz merged commit 669b51f into hyperledger-cacti:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izuru0 izuru0 izuru0 approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan approved these changes

@sandeepnRES sandeepnRES sandeepnRES approved these changes

@petermetz petermetz petermetz left review comments

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@outSH @petermetz @sandeepnRES @jagpreetsinghsasan @izuru0