fix(webpack): fix broken bundling - cannot find webpack.config.js #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepto98
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
deepto98
force-pushed
the
fix-cannot-find-webpack.config.js
branch
from
62f77f1
to
6a9d7d4
Compare
jagpreetsinghsasan
approved these changes
May 15, 2023
takeutak
approved these changes
May 23, 2023
sandeepnRES
force-pushed
the
fix-cannot-find-webpack.config.js
branch
2 times, most recently
from
9319570
to
760c778
Compare
petermetz
force-pushed
the
fix-cannot-find-webpack.config.js
branch
from
760c778
to
fe51632
Compare
Signed-off-by: deepto <ddepp98@outlook.com>
petermetz
force-pushed
the
fix-cannot-find-webpack.config.js
branch
from
fe51632
to
f239430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
examples/cactus-workshop-examples-2022-11-14package was causingyarn build:devto fail. This PR fixes the incorrect webpack config path in the example'spackage.jsonfile and adds a missing/src/main/typescript/index.web.tsfile.Fixes https://github.com/hyperledger/cacti/issues/2357
Signed-off-by: deepto98 ddepp98@outlook.com