ci(test-tooling): fix CI job failing due to with wasm-pack #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianbatuto
changed the title
adrianbatuto
changed the title
adrianbatuto
force-pushed
the
adrianbatuto/issue2407
branch
from
1a71521
to
e1129c5
Compare
adrianbatuto
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
takeutak
approved these changes
Jun 30, 2023
petermetz
changed the title
petermetz
requested changes
Jun 30, 2023
There was a problem hiding this comment.
@adrianbatuto LGTM on the diff but please
- Change the commit subject to what I just set the PR title to,
- Explain in the commit message body what was the fix and why (how did it fix the problem)
- Make sure that the PR description is synced up to the commit message
- Make sure that there is only one commit after your changes were made (e.g. amend the existing commit)
adrianbatuto
force-pushed
the
adrianbatuto/issue2407
branch
3 times, most recently
from
4d62723
to
f03838a
Compare
Updated the cactus-rust-compiler version to properly build the image and get the required files. Fixes hyperledger-cacti#2407 Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
petermetz
force-pushed
the
adrianbatuto/issue2407
branch
from
f03838a
to
7e0ff6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the cactus-rust-compiler version to properly build the image and get the required files.
Fixes https://github.com/hyperledger/cacti/issues/2407
Signed-off-by: adrianbatuto adrian.batuto@accenture.com