Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tessera): updated tessera version error in quorum-all-in-one #2411 #2549

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

ruzell22
Copy link
Contributor

fixes: #2411

related to: #2240 and #2274

Tessera version was updated and some flags were deprecated. It has been
fixed in this commit. Also, the quorum and tessera compatibility with
quorum-all-in-one. The container and image has been built and ran
successfully.

@ruzell22
Copy link
Contributor Author

docker run --priveleged --rm qaio successfully ran and built

image

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 Please also run one of the tests against the locally built image (by modifying the test case to use it) and then post the exact path of that test case here. Once we have that, we know for sure that it doesn't just work as in the image does boot without crashing, but also that the test cases are still passing with the new image changes.

Other than that, it looks good to me already. Thank you!

@ruzell22
Copy link
Contributor Author

@petermetz I have tested the following with launch.json JEST test:

• deploy-contract-via-web-service.test.ts (cactus/packages/cactus-test-plugin-ledger-connector-quorum/src/test/typescript/integration/plugin-ledger-connector-quorum/deploy-contract/deploy-contract-via-web-service.test.ts)
image

• v21.4.1-deploy-contract-from-json.test.ts (cactus/packages/cactus-plugin-ledger-connector-quorum/src/test/typescript/integration/plugin-ledger-connector-quorum/deploy-contract/v21.4.1-deploy-contract-from-json.test.ts)
image

• v21.4.1-invoke-contract.test.ts (cactus/packages/cactus-plugin-ledger-connector-quorum/src/test/typescript/integration/plugin-ledger-connector-quorum/deploy-contract/v21.4.1-invoke-contract.test.ts)
image

@ruzell22 ruzell22 requested a review from petermetz July 13, 2023 06:13
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for confirming @ruzell22 - LGTM!

@petermetz petermetz force-pushed the updatetesseraqaio2411 branch from b615ce4 to 5be685d Compare July 16, 2023 20:02
@petermetz petermetz enabled auto-merge (rebase) July 16, 2023 20:03
@petermetz petermetz merged commit 759f305 into hyperledger-cacti:main Jul 16, 2023
@petermetz petermetz deleted the updatetesseraqaio2411 branch July 16, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(tessera): updated tessera version error in quorum-all-in-one
3 participants