-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): Checks and CodedError classes #275
Merged
petermetz
merged 1 commit into
hyperledger-cacti:master
from
petermetz:feat/common/preconditions-coded-errors-266
Sep 11, 2020
Merged
feat(common): Checks and CodedError classes #275
petermetz
merged 1 commit into
hyperledger-cacti:master
from
petermetz:feat/common/preconditions-coded-errors-266
Sep 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilities for easier one-liners that can verify arguments or execution state in a much more concise way compared to if conditions throwing manually. Makes the code less verbose and requires less typing as well. Also: added a bools utlity class for checking strict boolean typing of a value and a new string utility method as well. Fixes hyperledger-cacti#266 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
Developer_Experience
labels
Sep 5, 2020
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 5, 2020
Helpers to list files under an arbitrary path in a container's file system and a more generic method that helps executing shell commands (exec()) Depends on hyperledger-cacti#275 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 5, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
jonathan-m-hamilton
approved these changes
Sep 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
takeutak
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 18, 2020
Helpers to list files under an arbitrary path in a container's file system and a more generic method that helps executing shell commands (exec()) Depends on hyperledger-cacti#275 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 18, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 25, 2020
Helpers to list files under an arbitrary path in a container's file system and a more generic method that helps executing shell commands (exec()) Depends on hyperledger-cacti#275 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this pull request
Oct 1, 2020
Helpers to list files under an arbitrary path in a container's file system and a more generic method that helps executing shell commands (exec()) Depends on #275 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 1, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 2, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 6, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Oct 7, 2020
Also fixes the issues in the fabric all in one image with file path typos, docker sock mounting, etc. Fixes hyperledger-cacti#252 Depends on hyperledger-cacti#275 Depends on hyperledger-cacti#276 Depends on hyperledger-cacti#277 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added a commit
that referenced
this pull request
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
Developer_Experience
enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilities for easier one-liners that can verify arguments or
execution state in a much more concise way compared to
if conditions throwing manually. Makes the code less verbose
and requires less typing as well.
Also: added a bools utlity class for checking strict boolean
typing of a value and a new string utility method as well.
Fixes #266
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com