-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add container scanning to default checks #2870
ci: add container scanning to default checks #2870
Conversation
606d9a5
to
dba6d22
Compare
dba6d22
to
229502f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zondervancalvez ^^ Please see @jagpreetsinghsasan 's comment above!
229502f
to
24c7850
Compare
24c7850
to
a6bb8b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zondervancalvez Please enable the trivy scanning for the production images (right now I see some AIO test images that are being tested that we can omit and save resources - but I also see one or two of the production images listed below that do not have the trivy scan added)
ghcr-cmd-api-server
ghcr-connector-besu
ghcr-connector-corda-server
ghcr-connector-fabric
ghcr-keychain-vault-server
d10e3ee
to
043d86c
Compare
6c496c3
to
d820fa3
Compare
d820fa3
to
2eeca3f
Compare
2eeca3f
to
273b859
Compare
d7fa656
to
f8b00ff
Compare
@jagpreetsinghsasan Have your review points been addressed? I think I saw that the trivy checks are now part of the same job that builds the container so there is no duplicate builds being performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Great, thank you!
@zondervancalvez Please resolve the merge conflicts and pass it back for review and then we can merge!
Trivy is a cutting-edge security tool designed to enhance the safety of containerized applications by conducting thorough vulnerability assessments. Specifically developed for scanning container images, ranging from low-severity issues to critical threats. It employs an intelligent rating system to categorize vulnerabilities based on their severity levels, ensuring that high to critical vulnerabilities are given special attention. Upon detecting vulnerabilities that fall within this elevated range, Trivy will throw an error. By integrating Trivy into our deployment pipeline, we can proactively mitigate security risks and enhance the resilience of our repository. Fixes hyperledger#1876 Depends On: hyperledger#2865 Depends On: hyperledger#2864 Depends On: hyperledger#2863 Depends On: hyperledger#2862 Signed-off-by: zondervancalvez <zondervan.v.calvez@accenture.com>
f8b00ff
to
eb6dbdf
Compare
Trivy is a cutting-edge security tool designed to enhance the safety of containerized applications by conducting thorough vulnerability assessments. Specifically developed for scanning container images, ranging from low-severity issues to critical threats. It employs an intelligent rating system to categorize vulnerabilities based on their severity levels, ensuring that high to critical vulnerabilities are given special attention. Upon detecting vulnerabilities that fall within this elevated range, Trivy will throw an error.
By integrating Trivy into our deployment pipeline, we can proactively mitigate security risks and enhance the resilience of our repository.
Fixes hyperledger#1876
Depends On: hyperledger#2865
Depends On: hyperledger#2864
Depends On: hyperledger#2863
Depends On: hyperledger#2862
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.