Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ledger-browser): refactor eth dashboard page #3237

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Apr 25, 2024

  • Refactor ETH app dashboard using MUI components.
  • Fix ERC20 details page rendering.
  • Add block and transaction list components that use common UITableListing.
  • Add global notifications that will be displayed in a snackbar.

Depends on #3207

Signed-off-by: Michal Bajer michal.bajer@fujitsu.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

outSH added a commit to outSH/cactus that referenced this pull request May 22, 2024
- This concludes refactoring of ethereum app, it should be fully usable
  with mostly same features as before.
- Refactor completely ETH app token page into accounts page
  using MUI components.
- Update materialized view in peristence plugin ethereum schema.
- Use hyperledger favicon from local files and not from the URL.
- Remove files and components that are not used anymore.
- Remove unnecessary package dependencies.

Depends on hyperledger-cacti#3237

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Refactor ETH app dashboard using MUI components.
- Fix ERC20 details page rendering.
- Add block and transaction list components that use common `UITableListing`.
- Add global notifications that will be displayed in a snackbar.

Depends on hyperledger-cacti#3207

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH force-pushed the refactor_gui_eth_app_pr branch from a3679d4 to 62beb4f Compare June 24, 2024 12:38
@outSH outSH enabled auto-merge (rebase) June 24, 2024 12:38
Copy link

This PR/issue depends on:

@outSH outSH merged commit c69fb4c into hyperledger-cacti:main Jun 24, 2024
149 of 150 checks passed
outSH added a commit to outSH/cactus that referenced this pull request Jun 25, 2024
- This concludes refactoring of ethereum app, it should be fully usable
  with mostly same features as before.
- Refactor completely ETH app token page into accounts page
  using MUI components.
- Update materialized view in peristence plugin ethereum schema.
- Use hyperledger favicon from local files and not from the URL.
- Remove files and components that are not used anymore.
- Remove unnecessary package dependencies.

Depends on hyperledger-cacti#3237

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
outSH added a commit that referenced this pull request Jun 25, 2024
- This concludes refactoring of ethereum app, it should be fully usable
  with mostly same features as before.
- Refactor completely ETH app token page into accounts page
  using MUI components.
- Update materialized view in peristence plugin ethereum schema.
- Use hyperledger favicon from local files and not from the URL.
- Remove files and components that are not used anymore.
- Remove unnecessary package dependencies.

Depends on #3237

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
sandeepnRES pushed a commit to sandeepnRES/cacti that referenced this pull request Jul 30, 2024
- This concludes refactoring of ethereum app, it should be fully usable
  with mostly same features as before.
- Refactor completely ETH app token page into accounts page
  using MUI components.
- Update materialized view in peristence plugin ethereum schema.
- Use hyperledger favicon from local files and not from the URL.
- Remove files and components that are not used anymore.
- Remove unnecessary package dependencies.

Depends on hyperledger-cacti#3237

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants