Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples/supply-chain-app): print correct web host in the CLI logs #3363

Conversation

petermetz
Copy link
Contributor

  1. The logs were showing the bound host which in our case was 0.0.0.0
    but that is not accepted by web browsers when you are executing HTTP XHR
    requests from Javascript.
  2. This change makes it so that even though we bind to 0.0.0.0 the logs
    to the person running the example application will show 127.0.0.1.
    This might potentially cause further confusion in some people who'd think
    that we are binding to 127.0.0.1 based on the logs, but this seems like an
    acceptable trade-off for an example which has the number one priority of
    being easily digestable.

Fixes #2390

Depends on #3362

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz enabled auto-merge (rebase) June 27, 2024 01:56
@petermetz petermetz force-pushed the docs-examples-supply-chain-app-readme-localhost-fix branch from f79f8ee to fefd726 Compare June 27, 2024 03:38
@petermetz petermetz changed the title Docs-examples-supply-chain-app-readme-localhost-fix docs(examples/supply-chain-app): print correct web host in the CLI logs Jun 28, 2024
@petermetz petermetz changed the title docs(examples/supply-chain-app): print correct web host in the CLI logs docs(examples/supply-chain-app): print correct web host in the CLI logs Jul 1, 2024
@github-actions github-actions bot removed the dependent label Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

This PR/issue depends on:

1. The logs were showing the bound host which in our case was 0.0.0.0
but that is not accepted by web browsers when you are executing HTTP XHR
requests from Javascript.
2. This change makes it so that even though we bind to 0.0.0.0 the logs
to the person running the example application will show 127.0.0.1.
This might potentially cause further confusion in some people who'd think
that we are binding to 127.0.0.1 based on the logs, but this seems like an
acceptable trade-off for an example which has the number one priority of
being easily digestable.

Fixes hyperledger-cacti#2390

Depends on hyperledger-cacti#3362

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the docs-examples-supply-chain-app-readme-localhost-fix branch from fefd726 to 7bac569 Compare July 1, 2024 16:53
@petermetz petermetz merged commit fa190ed into hyperledger-cacti:main Jul 1, 2024
149 of 151 checks passed
@petermetz petermetz deleted the docs-examples-supply-chain-app-readme-localhost-fix branch July 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(examples/supply-chain-app): print correct web host in the CLI logs
3 participants