Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(sync-ts-config): fix no such file or directory protos-js/tsconfig.json #3367

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Jun 28, 2024

Commit to be reviewed


build(sync-ts-config): fix no such file or directory protos-js/tsconfig.json

Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script will run successfully

Fixes: #3069
Related to: #3366

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 Overall, looking good, but I have a few nits as usual. See the above comments and also one here: Please use a PR title and commit message that is an exact match to the issue title.

tools/sync-npm-deps-to-tsc-projects.ts Show resolved Hide resolved
tools/sync-npm-deps-to-tsc-projects.ts Show resolved Hide resolved
@petermetz
Copy link
Contributor

@ruzell22 I figured it out! Our sync-ts-config script assumes that the tsconfig is in the package's top level directory (e.g. ./packages/my-package/ but for this package the location of it's wrong so the fix is probably to relocate the tsconfig file to the expected path. So, move
packages/cacti-plugin-weaver-driver-fabric/src/main/typescript/tsconfig.json to
packages/cacti-plugin-weaver-driver-fabric/tsconfig.json

@ruzell22 ruzell22 changed the title fix(sync-ts-config): fix no such file or directory tsconfig.json build(sync-ts-config): fix no such file or directory protos-js/tsconfig.json Jul 4, 2024
@ruzell22 ruzell22 requested a review from petermetz July 4, 2024 05:49
…ig.json

Primary Changes
---------------

1. Fix issue with the object key
2. Temporarily added ignore paths for the missing tsconfig.json so the script will run successfully

Fixes: hyperledger-cacti#3069
Related to: hyperledger-cacti#3366

Signed-off-by: ruzell22 <ruzell.vince.aquino@accenture.com>
@petermetz petermetz enabled auto-merge (rebase) July 5, 2024 20:54
@petermetz petermetz merged commit 29ec45c into hyperledger-cacti:main Jul 5, 2024
146 of 150 checks passed
@petermetz petermetz deleted the synctsconfig3069 branch July 5, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(sync-ts-config): fix no such file or directory protos-js/tsconfig.json
3 participants