Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(sync-ts-config): integrating the weaver packages to the monorepo build #3400

Closed
wants to merge 1 commit into from
Closed

build(sync-ts-config): integrating the weaver packages to the monorepo build #3400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/sync-npm-deps-to-tsc-projects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const main = async (argv: string[], env: NodeJS.ProcessEnv) => {
"**/weaver/common/protos-js/**",
"**/weaver/samples/besu/simpleasset/**",
"**/weaver/samples/besu/simplestate/**",
], // Follow-up issue regarding these hardcoded paths (https://github.com/hyperledger/cacti/issues/3366)
], //Follow-up issue regarding these hardcoded paths (https://github.com/hyperledger/cacti/issues/3366)
Copy link
Contributor

@sandeepnRES sandeepnRES Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the only reason for this PR? one whitespace removal? I don't see any other changes in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sandeepnRES @VRamakrishna Agreed. That would actually cause a linter warning if we removed that space character so this PR is probably good to close as a no-op then.

};
const pkgJsonPaths = await globby(pkgJsonGlobPatterns, globbyOptions);
console.log(`Package paths (${pkgJsonPaths.length}): `, pkgJsonPaths);
Expand Down
Loading