Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-daml): aio image #3411

Merged

Conversation

raynatopedrajeta
Copy link
Contributor

@raynatopedrajeta raynatopedrajeta commented Jul 15, 2024

Commit to be reviewed


feat(connector-daml): aio image

Primary Changes
----------------
1. Create a docker image on daml-all-in-one folder that contains an initial creation of DAML smart contracts

Fixes #3284

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@jagpreetsinghsasan
Copy link
Contributor

@raynatopedrajeta please fix the PR message and the commit message (similar to how you did earlier, in your previous PR)

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR from a possible merge, until the review comments are addressed.

tools/docker/daml-all-in-one/Dockerfile Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 3 times, most recently from eaa8712 to 455ca58 Compare July 15, 2024 09:37
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 3 times, most recently from 5f432b0 to f1b93d3 Compare July 17, 2024 06:28
tools/docker/daml-all-in-one/healthcheck.sh Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/daml-all-in-one.yaml Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/daml-all-in-one.yaml Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 3 times, most recently from c095289 to ed66bb3 Compare July 19, 2024 10:20
Copy link

gitguardian bot commented Jul 19, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

tools/docker/daml-all-in-one/.env Outdated Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 2 times, most recently from de49001 to 54c611a Compare July 24, 2024 09:22
tools/docker/daml-all-in-one/daml-all-in-one.yaml Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/script.sh Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Dockerfile Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/healthcheck.sh Outdated Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 2 times, most recently from 345b325 to feca662 Compare July 26, 2024 08:58
.github/workflows/daml-all-in-one.yaml Outdated Show resolved Hide resolved
.github/workflows/daml-all-in-one.yaml Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 2 times, most recently from 51e6967 to c822be3 Compare August 2, 2024 02:23
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
tools/docker/daml-all-in-one/Readme.md Outdated Show resolved Hide resolved
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3284 branch 3 times, most recently from 176a870 to 6b1fb0f Compare August 6, 2024 11:51
Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the updates!

@petermetz
Copy link
Contributor

@jagpreetsinghsasan Are we good to go from your side?

@jagpreetsinghsasan
Copy link
Contributor

Yes @petermetz , good to merge from my end.

@petermetz petermetz dismissed jagpreetsinghsasan’s stale review August 13, 2024 01:24

Jagpreet confirmed that the requests have been made.

Primary Changes
---------------
1. Create a docker image on daml-all-in-one folder that contains
an initial creation of DAML smart contracts
Fixes hyperledger-cacti#3284
Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
@petermetz petermetz merged commit 141ee24 into hyperledger-cacti:main Aug 13, 2024
142 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(connector-daml): aio image
4 participants