ci(release-automation): make release issuance atomic #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NodeJS package publishing GitHub workflow job will now publish all packages to both GHCR and npmjs.org registries. It dynamically reconfigures the .npmrc file with the appropriate registry URL and the correct token gets set through the environment variables as well. The lerna publish script gets invoked twice, with different registry configurations which was the only way I found to make sure that all the packages are deployed to all the locations where they are to be used. Fixes hyperledger-cacti#451 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
added a commit
that referenced
this pull request
Sep 30, 2024
In addition to being a regular release candidate, this also includes a (probable) fix for the npm/ghcr publishing github action. The above fix is the entire reason why we are issuing this release to begin with: to verify that the automatic publishing script works before issuing the v2.0.0 GA release after long last. Depends on #3563 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
5 tasks
jagpreetsinghsasan
approved these changes
Sep 30, 2024
outSH
approved these changes
Oct 1, 2024
petermetz
added a commit
that referenced
this pull request
Oct 1, 2024
In addition to being a regular release candidate, this also includes a (probable) fix for the npm/ghcr publishing github action. The above fix is the entire reason why we are issuing this release to begin with: to verify that the automatic publishing script works before issuing the v2.0.0 GA release after long last. Depends on #3563 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NodeJS package publishing GitHub workflow job will now publish
all packages to both GHCR and npmjs.org registries.
It dynamically reconfigures the .npmrc file with the appropriate registry
URL and the correct token gets set through the environment variables as well.
The lerna publish script gets invoked twice, with different registry configurations
which was the only way I found to make sure that all the packages are deployed
to all the locations where they are to be used.
Fixes #451
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.