Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId #3587

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

petermetz
Copy link
Contributor

In the DeployContractSolidityBytecodeNoKeychainV1Request of
packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes #3586

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the DeployContractSolidityBytecodeNoKeychainV1Request of
`packages/cactus-plugin-ledger-connector-besu/src/main/json/openapi.tpl.json`
there are parameters that are required despite the entire point of this
operation is to not need them (e.g. keychainId and contract JSON object).

Fixes hyperledger-cacti#3586

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz
Copy link
Contributor Author

petermetz commented Oct 17, 2024

I investigated why the DAST scan is failing but could not reproduce the problem locally. I'm going to assume that it's an issue with the environment setup logic of the CI job and not an issue with the endpoints. Based on that I'll disable the DAST scan for now until we can figure out what's wrong with it.

Tracking the fix here: #3596

@petermetz petermetz merged commit 11dacbc into hyperledger-cacti:main Oct 17, 2024
143 of 146 checks passed
@petermetz petermetz deleted the petermetz/issue3586 branch October 17, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(besu): deployContractSolBytecodeNoKeychainV1 requires keychainId
3 participants