Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dast): ccp, sshconfig missing #3676

Conversation

raynatopedrajeta
Copy link
Contributor

@raynatopedrajeta raynatopedrajeta commented Dec 6, 2024

Commit to be reviewed


fix(dast) :ccp, sshconfig missing

Primary Changes
----------------
1.Fix the issue on plugin-ledger-connector-fabric that throws an error when
there is no sshConfig available.

Fixes #3671

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@raynatopedrajeta raynatopedrajeta changed the title bug(dast):ccp, sshconfig missing fix(dast):ccp, sshconfig missing Dec 6, 2024
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch from ba270e1 to 4da6f88 Compare December 6, 2024 11:18
@raynatopedrajeta raynatopedrajeta changed the title fix(dast):ccp, sshconfig missing fix(dast): ccp, sshconfig missing Dec 6, 2024
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch 3 times, most recently from 5f7ff7a to 75f266e Compare December 6, 2024 12:21
Primary Changes
----------------
1. Fix the issue on plugin-ledger-connector-fabric that throws an error when
there is no sshConfig available.

Fixes hyperledger-cacti#3671

Signed-off-by: raynato.c.pedrajeta <raynato.c.pedrajeta@accenture.com>
@raynatopedrajeta raynatopedrajeta force-pushed the raynatopedrajeta/issue3671 branch from 75f266e to 67e846e Compare December 6, 2024 12:36
@raynatopedrajeta
Copy link
Contributor Author

raynatopedrajeta commented Dec 6, 2024

Hello @petermetz ,

FYI, run has proceeded. However, I am getting this timeout issue upon multiple tries:
Screenshot 2024-12-06 at 8 51 11 PM

Thank you!

Rayn

@jagpreetsinghsasan
Copy link
Contributor

@raynatopedrajeta basically we have to update the code in a way, the fabric plugin import in DAST scan doesn't change (very much fixable in my opinion). Please have a look again into this when you are back from leave. Closing the PR as this PR doesn't provide the correct solution and also breaks the DAST scan completely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(dast): ccp, sshconfig missing
2 participants