fix(npm): clean script was missing folders #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
added
bug
1. No longer uses lerna and instead specifies glob patterns 2. Expands the deletion of generated Typescript code to all packages where it's present not just the api-client package. 3. Deletes the two files that were meant to be deleted to begin with, but since the clean script was not fully working they were actually left undeleted until now. Fixes hyperledger-cacti#469 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
fix/npm/clean-script-del-cli-syntax-469
branch
from
4eb4222 to
cd7d4f7
Compare
takeutak
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages where it's present not just the api-client package.
Fixes #469
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com