feat(fabric): prometheus exporter support #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagpreetsinghsasan
requested review from
jonathan-m-hamilton and
petermetz
as code owners
jagpreetsinghsasan
changed the title
jagpreetsinghsasan
force-pushed
the
feature-458
branch
2 times, most recently
from
897f62d
to
070030e
Compare
petermetz
requested changes
Feb 10, 2021
...tor-fabric/src/test/typescript/integration/fabric-v1-4-x/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
...ic/src/main/typescript/get-prometheus-exporter-metrics/get-prometheus-exporter-metrics-v1.ts
Outdated
Show resolved
Hide resolved
petermetz
reviewed
Feb 10, 2021
...ic/src/main/typescript/get-prometheus-exporter-metrics/get-prometheus-exporter-metrics-v1.ts
Outdated
Show resolved
Hide resolved
petermetz
reviewed
Feb 10, 2021
...lugin-ledger-connector-fabric/src/main/typescript/prometheus-exporter/prometheus-exporter.ts
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 10, 2021
...lugin-ledger-connector-fabric/src/main/typescript/prometheus-exporter/prometheus-exporter.ts
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 10, 2021
...tor-fabric/src/test/typescript/integration/fabric-v1-4-x/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
jagpreetsinghsasan
force-pushed
the
feature-458
branch
3 times, most recently
from
0ba55f4
to
7bac798
Compare
petermetz
requested changes
Feb 18, 2021
...in/typescript/get-prometheus-exporter-metrics/get-prometheus-exporter-metrics-endpoint-v1.ts
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 18, 2021
packages/cactus-plugin-ledger-connector-fabric/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-fabric/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-fabric/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 18, 2021
.../cactus-plugin-ledger-connector-fabric/src/main/typescript/plugin-ledger-connector-fabric.ts
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 18, 2021
...ages/cactus-plugin-ledger-connector-fabric/src/main/typescript/prometheus-exporter/Readme.md
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 18, 2021
...tor-fabric/src/test/typescript/integration/fabric-v2-2-x/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Feb 18, 2021
...ges/cactus-plugin-ledger-connector-fabric/src/main/typescript/prometheus-exporter/metrics.ts
Outdated
Show resolved
Hide resolved
jagpreetsinghsasan
force-pushed
the
feature-458
branch
5 times, most recently
from
7759712
to
15da03e
Compare
petermetz
previously approved these changes
Feb 24, 2021
jagpreetsinghsasan
force-pushed
the
feature-458
branch
from
15da03e
to
b904f0c
Compare
Primary Change -------------- 1. The fabric ledger connector plugin now includes the prometheus metrics exporter integration 2. OpenAPI spec now has api endpoint for the getting the prometheus metrics Refactorings that were also necessary to accomodate 1) and 2) ------------------------------------------------------------ 3. The generate-sdk command now has DateTime mapping to Date (to read Date as Date object instead of string) 4. GetPrometheusMetricsV1 class is created to handle the corresponding api endpoint 5. IPluginLedgerConnectorFabricOptions interface in PluginLedgerConnectorFabric class now has a prometheusExporter optional field 6. The PluginLedgerConnectorFabric class has relevant functions and codes to incorporate prometheus exporter 7. run-transaction-endpoint-v1.test is changed to incorporate the prometheus exporter for both fabric 1.4.x and 2.x versions 8. Added Readme.md on the prometheus exporter usage Fixes hyperledger-cacti#531 Signed-off-by: Jagpreet Singh Sasan <jagpreet.singh.sasan@accenture.com>
jagpreetsinghsasan
force-pushed
the
feature-458
branch
from
b904f0c
to
8459fc6
Compare
petermetz
approved these changes
Feb 26, 2021
takeutak
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(fabric): add prometheus metrics support to the openapi specs of the plugin
Sub issue of #458
Fixes #531