-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): add build script decision tree #637
docs(readme): add build script decision tree #637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fc6fc1e
to
d7470c4
Compare
d7470c4
to
2c16f37
Compare
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
2c16f37
to
f602431
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f602431
to
4f2efc3
Compare
@petermetz Sorry for late replying. I think there is no problem with the contents of the PR, but could you put the original file that can be modified of the png image (./docs/images/build-script-decision-tree-2021-03-06.png) in the subdirectory if you have it? I also plan to add LedgerPlugin desicison tree later. |
4f2efc3
to
15a9440
Compare
@takeutak Done. |
Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
15a9440
to
e8c15ee
Compare
Dependencies
Depends on #656
Commit to be reviewed
Also: add links to the BUILD.md and CONTRIBUTING.md files.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com