Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add build script decision tree #637

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Mar 7, 2021

Dependencies

Depends on #656

Commit to be reviewed

Also: add links to the BUILD.md and CONTRIBUTING.md files.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

@petermetz petermetz added documentation Improvements or additions to documentation Developer_Experience labels Mar 7, 2021
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz enabled auto-merge (rebase) March 8, 2021 22:33
@petermetz petermetz disabled auto-merge March 11, 2021 17:53
@petermetz petermetz force-pushed the docs/readme/build-script-decision-tree branch 2 times, most recently from fc6fc1e to d7470c4 Compare March 24, 2021 01:44
@petermetz petermetz force-pushed the docs/readme/build-script-decision-tree branch from d7470c4 to 2c16f37 Compare March 24, 2021 02:19
@petermetz
Copy link
Contributor Author

@sfuji822 @takeutak Pushed changes according to the change requests.

@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@petermetz petermetz force-pushed the docs/readme/build-script-decision-tree branch from 2c16f37 to f602431 Compare March 28, 2021 05:00
@jonathan-m-hamilton jonathan-m-hamilton self-requested a review March 30, 2021 03:25
Copy link
Contributor

@jonathan-m-hamilton jonathan-m-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz
Copy link
Contributor Author

@sfuji822 @takeutak Kindly requesting that you review this pull request. Thank you very much in advance.

@petermetz petermetz force-pushed the docs/readme/build-script-decision-tree branch from f602431 to 4f2efc3 Compare April 5, 2021 18:27
@petermetz
Copy link
Contributor Author

@sfuji822 @takeutak Kindly requesting that you review this pull request. Thank you very much in advance.

@takeutak
Copy link
Contributor

takeutak commented Apr 17, 2021

@petermetz Sorry for late replying. I think there is no problem with the contents of the PR, but could you put the original file that can be modified of the png image (./docs/images/build-script-decision-tree-2021-03-06.png) in the subdirectory if you have it? I also plan to add LedgerPlugin desicison tree later.

@petermetz petermetz force-pushed the docs/readme/build-script-decision-tree branch from 4f2efc3 to 15a9440 Compare April 17, 2021 22:14
@petermetz
Copy link
Contributor Author

build-script-decision-tree-2021-03-06

@takeutak Done.
This already covers the ledger plugins as-is though so no need to modify AFAICT.

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the docs/readme/build-script-decision-tree branch from 15a9440 to e8c15ee Compare April 19, 2021 20:26
@petermetz petermetz merged commit c3b530a into hyperledger-cacti:main Apr 26, 2021
@petermetz petermetz deleted the docs/readme/build-script-decision-tree branch April 26, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer_Experience documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants