-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(example): example extended with fabric #640
docs(example): example extended with fabric #640
Conversation
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
a3ca0a4
to
bb2b44a
Compare
examples/cactus-example-supply-chain-backend/src/main/typescript/supply-chain-app.ts
Outdated
Show resolved
Hide resolved
...usiness-logic-plugin/src/main/typescript/business-logic-plugin/supply-chain-cactus-plugin.ts
Show resolved
Hide resolved
...usiness-logic-plugin/src/main/typescript/business-logic-plugin/supply-chain-cactus-plugin.ts
Show resolved
Hide resolved
...src/main/typescript/business-logic-plugin/web-services/insert-shipment-endpoint-constants.ts
Outdated
Show resolved
Hide resolved
000512a
to
d75234d
Compare
...usiness-logic-plugin/src/main/typescript/business-logic-plugin/supply-chain-cactus-plugin.ts
Show resolved
Hide resolved
@jordigiam CI is failing due to it running out of disk space[1] which I remedied successfully in the past by adding this to the test where it gives out, same thing as here: // Always set to true when GitHub Actions is running the workflow.
// You can use this variable to differentiate when tests are being run locally or by GitHub Actions.
// @see https://docs.github.com/en/actions/reference/environment-variables
if (process.env.GITHUB_ACTIONS === "true") {
// Github Actions started to run out of disk space recently so we have this
// hack here to attempt to free up disk space when running inside a VM of
// the CI system.
await Containers.pruneDockerResources();
} [1]: ail out! packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v1-4-x/run-transaction-endpoint-v1.test.ts
internal/fs/utils.js:220
throw err;
^
Error: ENOSPC: no space left on device, write
at Object.writeSync (fs.js:581:3)
at Object.writeFileSync (fs.js:1275:26)
at NYC.writeProcessIndex (/home/runner/work/cactus/cactus/node_modules/nyc/index.js:490:8)
at /home/runner/work/cactus/cactus/node_modules/nyc/bin/nyc.js:68:9
at ChildProcess.<anonymous> (/home/runner/work/cactus/cactus/node_modules/foreground-child/index.js:52:5)
at ChildProcess.emit (events.js:210:5)
at ChildProcess.EventEmitter.emit (domain.js:476:20)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5) {
errno: -28,
syscall: 'write',
code: 'ENOSPC'
} |
d75234d
to
10ed775
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordigiam @AzaharaC Looks legit.
TLDR:
I made some fixes/chores/docs changes, is it okay to force push? Didn't want to accidentally erase your work.
Story:
When testing locally, the docker image build wasn't working for me because I broke it in a PR of mine a few weeks back (corda connector) so I added a hotfix for that in a commit that I recommend to keep separate from the main PR commit (so the PR would have 2 commits which is fine in this case IMO because I did not want to complicate things even further by opening a separate PR with the hot-fix and then have this one wait for that and be forced to depend on multiple parent branches, etc...)
The other thing I did was publishing the container image to DockerHub under a new tag and updated the READMEs to use that image so that once we merge this PR, everyone will see the latest example in the root readme with Fabric included.
I have all the above on a branch on my work because I did not want to risk force pushing onto this and then erasing something that you were working on (but if you confirm that it's cool then I'll go ahead and perform the force push).
https://github.com/petermetz/cactus/tree/feature/extend-example-fabric
@petermetz I have been reviewing your changes and I think that the push can be done without problems, so do it. |
Why though? Because if you are building the project during the building of the supply chain app example container image, then the "generate-server" script of the corda connector was failing due to a running docker daemon not being present in the image at build time (even with the docker-in-docker base image because that also only has a docker daemon running at runtime of the container not at build time). Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
10ed775
to
02af31c
Compare
Signed-off-by: jordigiam <jordi.giron.amezcua@accenture.com>
02af31c
to
a96ba92
Compare
@takeutak Review was dismissed because of conflict resolution, could you please approve again? Thank you in advance! |
Resolve #362
Depends on #616
Depends on #634