feat(test-tooling): pruneDockerResources() observability #694 #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cacti#694 Primary change ----------------------- Adds request and response definitions to the pruneDockerResources() method to allow callers to control the log levels and also to get a complete report of the pruning processes' outcome from the returned object instead of just returning with `void`. Miscellaneous changes ---------------------------------- Significantly improved the documentation for the utility method in question. Fixes hyperledger-cacti#694 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
documentation
This was referenced Mar 22, 2021
takeutak
approved these changes
Mar 23, 2021
|
Will merge this without the CI passing due to this being a dependency of the hot-fix that will (hopefully) make the false negatives go away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary change
Adds request and response definitions to
the pruneDockerResources() method to
allow callers to control the log levels
and also to get a complete report of the
pruning processes' outcome from the
returned object instead of just returning
with
void.Miscellaneous changes
Significantly improved the documentation
for the utility method in question.
Fixes #694
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com