ci: use tools/ci.sh in Github Actions #497 #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeutak
approved these changes
Mar 25, 2021
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
Primary change ============= While we were getting to know the GitHub Actions CI runner we temporarily stopped using the tools/ci.sh script to run the tests, but now that we are properly familiarized with GHA and it's quirks, it is time to go back to the good old script we've been using before migrating over to GHA for CI. Secondary change ================ Add retries to the tests to minimize the amount of failures due to flake where manual intervention is needed (e.g. manually restarting the tests after a false negative). This will also not make the false negatives go away 100% but the hope is that it will reduce them in numbers and therefore make it a little less annoying for contributors who send PRs. Fixes hyperledger-cacti#497 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies
Depends on #656
Depends on #674
Commit to review
ci: use tools/ci.sh in Github Actions #497
While we were getting to know the GitHub Actions CI runner
we temporarily stopped using the tools/ci.sh script
to run the tests, but now that we are properly
familiarized with GHA and it's quirks, it is time to
go back to the good old script we've been using before migrating
over to GHA for CI.
Fixes #497
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com