feat(connector-besu, connector-quorum): replace invokeContractV2 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzaharaC
force-pushed
the
feature/invoke-to-invokev2
branch
2 times, most recently
from
5160dba to
faae6a1
Compare
AzaharaC
requested review from
jonathan-m-hamilton and
petermetz
as code owners
petermetz
reviewed
Mar 26, 2021
| @@ -26,7 +26,7 @@ export class InvokeContractEndpoint implements IWebServiceEndpoint { | |||
|
|
|||
| private readonly log: Logger; | |||
|
|
|||
| public get className() { | |||
| public get className(): string { | |||
There was a problem hiding this comment.
@AzaharaC Thanks for fixing the occasional linter warning! It matters in the long run.
petermetz
requested changes
Mar 26, 2021
...ly-chain-backend/src/main/typescript/infrastructure/supply-chain-app-dummy-infrastructure.ts
Outdated
Show resolved
Hide resolved
...ly-chain-backend/src/main/typescript/infrastructure/supply-chain-app-dummy-infrastructure.ts
Outdated
Show resolved
Hide resolved
examples/cactus-example-supply-chain-backend/src/main/typescript/supply-chain-app.ts
Outdated
Show resolved
Hide resolved
examples/cactus-example-supply-chain-backend/src/main/typescript/supply-chain-app.ts
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-besu/src/main/typescript/plugin-ledger-connector-besu.ts
Show resolved
Hide resolved
...integration/plugin-ledger-connector-quorum/deploy-contract/deploy-contract-from-json.test.ts
Show resolved
Hide resolved
...integration/plugin-ledger-connector-quorum/deploy-contract/deploy-contract-from-json.test.ts
Show resolved
Hide resolved
...integration/plugin-ledger-connector-quorum/deploy-contract/deploy-contract-from-json.test.ts
Show resolved
Hide resolved
...integration/plugin-ledger-connector-quorum/deploy-contract/deploy-contract-from-json.test.ts
Show resolved
Hide resolved
...script/integration/plugin-ledger-connector-quorum/deploy-contract/invoke-contract-v2.test.ts
Show resolved
Hide resolved
AzaharaC
force-pushed
the
feature/invoke-to-invokev2
branch
from
faae6a1 to
46f8519
Compare
AzaharaC
force-pushed
the
feature/invoke-to-invokev2
branch
from
46f8519 to
e873b52
Compare
jordigiam
changed the title
jordigiam
force-pushed
the
feature/invoke-to-invokev2
branch
2 times, most recently
from
90837d3 to
88a2af9
Compare
AzaharaC
force-pushed
the
feature/invoke-to-invokev2
branch
from
88a2af9 to
150608b
Compare
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
petermetz
approved these changes
Apr 15, 2021
takeutak
approved these changes
Apr 17, 2021
|
@AzaharaC @jordigiam Let me know if you need help with conflict resolution! |
AzaharaC
force-pushed
the
feature/invoke-to-invokev2
branch
from
150608b to
a3b962c
Compare
petermetz
force-pushed
the
feature/invoke-to-invokev2
branch
from
a3b962c to
9ba9412
Compare
|
@AzaharaC I did the rebase, now there's a failure that looks like a legit test failure that's worth looking into => https://github.com/hyperledger/cactus/pull/731/checks?check_run_id=2383092323#step:5:14645 |
I'm going to check this error UPDATE: error fixed. |
AzaharaC
force-pushed
the
feature/invoke-to-invokev2
branch
from
9ba9412 to
ec16503
Compare
Signed-off-by: AzaharaC <a.castano.benito@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #679
Depends on #702