Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector-quorum): containerize plugin #803

Merged

Conversation

jordigiam
Copy link

@jordigiam jordigiam commented Apr 16, 2021

Resolve #787

Depends on #839

@jordigiam jordigiam force-pushed the feature/containerize-quorum branch 4 times, most recently from a14be0d to 084f6ea Compare April 21, 2021 14:37
@jordigiam jordigiam marked this pull request as ready for review April 21, 2021 14:40
@jordigiam jordigiam requested review from takeutak and sfuji822 April 21, 2021 14:40
Signed-off-by: jordigiam <jordi.giron.amezcua@accenture.com>
@jordigiam jordigiam force-pushed the feature/containerize-quorum branch from 084f6ea to a47455e Compare April 21, 2021 15:00
@jordigiam jordigiam requested a review from petermetz April 21, 2021 15:01
@petermetz petermetz self-requested a review April 22, 2021 21:07
@petermetz petermetz removed the request for review from jonathan-m-hamilton July 20, 2021 19:04
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #803 (1300714) into main (1a5edea) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
+ Coverage   70.37%   70.39%   +0.01%     
==========================================
  Files         302      302              
  Lines       10902    10902              
  Branches     1332     1332              
==========================================
+ Hits         7672     7674       +2     
+ Misses       2528     2526       -2     
  Partials      702      702              
Impacted Files Coverage Δ
...main/typescript/rustc-container/rustc-container.ts 68.53% <0.00%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5edea...1300714. Read the comment docs.

@github-actions github-actions bot removed the dependent label Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@petermetz petermetz merged commit d016678 into hyperledger-cacti:main Oct 7, 2021
@petermetz petermetz deleted the feature/containerize-quorum branch October 7, 2021 22:59
@elenaizaguirre
Copy link
Contributor

@petermetz These are the old changes, I didn't push my changes yet. Do you want me to forget about this issue for now and keep these changes?

@petermetz
Copy link
Contributor

@elenaizaguirre Please push them to a separate branch and send a link and then let's continue the discussion there (with the diff being visible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(connector-quorum): containerize plugin
5 participants