Skip to content

Commit

Permalink
Remove CountQueryAsLoad Option
Browse files Browse the repository at this point in the history
Also fixes
1. unused timeout property in fabric gateway connectors
2. ignore license check in generator tests for downloaded files

Doc update to follow

Signed-off-by: D <d_kelsey@uk.ibm.com>
  • Loading branch information
D committed Mar 22, 2022
1 parent 4356663 commit 193d927
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion packages/caliper-core/lib/common/config/Config.js
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ const keys = {
LoadBalancing: 'caliper-fabric-loadbalancing',
OverwriteGopath: 'caliper-fabric-overwritegopath',
LatencyThreshold: 'caliper-fabric-latencythreshold',
CountQueryAsLoad: 'caliper-fabric-countqueryasload',
SkipCreateChannelPrefix: 'caliper-fabric-skipcreatechannel-',
Gateway: {
Enabled: 'caliper-fabric-gateway-enabled',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ class V1FabricGateway extends ConnectorBase {
this.context = undefined;

// this value is hardcoded, if it's used, that means that the provided timeouts are not sufficient
this.configSmallestTimeout = 1000;
this.configDefaultTimeout = ConfigUtil.get(ConfigUtil.keys.Fabric.Timeout.InvokeOrQuery, 60);
this.configCountQueryAsLoad = ConfigUtil.get(ConfigUtil.keys.Fabric.CountQueryAsLoad, true);

// Gateway connector
this.configLocalHost = ConfigUtil.get(ConfigUtil.keys.Fabric.Gateway.LocalHost, true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ class V1Fabric extends ConnectorBase {
this.configLatencyThreshold = ConfigUtil.get(ConfigUtil.keys.Fabric.LatencyThreshold, 1.0);
this.configDefaultTimeout = ConfigUtil.get(ConfigUtil.keys.Fabric.Timeout.InvokeOrQuery, 60);
this.configClientBasedLoadBalancing = ConfigUtil.get(ConfigUtil.keys.Fabric.LoadBalancing, 'client') === 'client';
this.configCountQueryAsLoad = ConfigUtil.get(ConfigUtil.keys.Fabric.CountQueryAsLoad, true);

this.transactionCounter = -1;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,7 @@ class V2FabricGateway extends ConnectorBase {
this.context = undefined;

// Timeouts
this.configSmallestTimeout = 1000;
this.configDefaultTimeout = ConfigUtil.get(ConfigUtil.keys.Fabric.Timeout.InvokeOrQuery, 60);
this.configCountQueryAsLoad = ConfigUtil.get(ConfigUtil.keys.Fabric.CountQueryAsLoad, true);

// Gateway connector
this.configLocalHost = ConfigUtil.get(ConfigUtil.keys.Fabric.Gateway.LocalHost, true);
Expand Down
4 changes: 3 additions & 1 deletion packages/caliper-tests-integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@
"fisco-bcos_tests/config/node3",
"fisco-bcos_tests/config/sdk",
"generator_tests/fabric/.gitignore",
"generator_tests/fabric/config/.gitignore"
"generator_tests/fabric/config/.gitignore",
"generator_tests/fabric/config/bin",
"generator_tests/fabric/config/config"
],
"file_type_method": "EXCLUDE",
"file_types": [
Expand Down

0 comments on commit 193d927

Please sign in to comment.