add update function for docker agent #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeasy
requested changes
Jan 30, 2021
| elif act == 'update': | ||
|
|
||
| env = { | ||
| 'HLF_NODE_MSP': request.form.get('msp'), |
There was a problem hiding this comment.
Need to ignore empty values.
And add test result in the commit msg.
dexhunter
force-pushed
the
add-update-function
branch
from
d7f1390 to
e9c9d98
Compare
|
@yeasy I did not find |
|
The test results are ok: |
dexhunter
force-pushed
the
add-update-function
branch
from
e9c9d98 to
04b046c
Compare
You should create a new update.sh. The image is built from the cello-hlf Dockerfile. |
dexhunter
force-pushed
the
add-update-function
branch
from
04b046c to
858fe19
Compare
dexhunter
commented
Feb 20, 2021
| data = { | ||
| 'msp':base64.b64encode(node_msp.read()), | ||
| 'tls':base64.b64encode(tls.read()), | ||
| 'bootstrap_block':base64.b64encode(block.read()), | ||
| 'peer_config_file':base64.b64encode(peer_config.read()), | ||
| 'orderer_config_file':base64.b64encode(orderer_config.read()), | ||
| 'img': 'yeasy/hyperledger-fabric:2.2.0', | ||
| # 'img': 'yeasy/hyperledger-fabric:2.2.0', |
There was a problem hiding this comment.
@yeasy Do I need to delete this line or can I leave for a reference?
There was a problem hiding this comment.
Better change it to hyperledger/cello-hlf:2.2.0.
dexhunter
force-pushed
the
add-update-function
branch
from
858fe19 to
0526fb1
Compare
|
@yeasy ok, I've changed accordingly |
dexhunter
force-pushed
the
add-update-function
branch
from
0526fb1 to
74d7cc5
Compare
* add update function * add update.sh at docker image * add test Signed-off-by: Dixing (Dex) Xu <dixingxu@gmail.com>
dexhunter
force-pushed
the
add-update-function
branch
from
74d7cc5 to
5d72295
Compare
yeasy
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dixing (Dex) Xu dixingxu@gmail.com