Endless block streaming #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
# Conflicts: # modules/client/src/test/kotlin/jp/co/soramitsu/iroha2/BlockStreamTest.kt
arndey
commented
Jul 14, 2023
modules/client/src/main/kotlin/jp/co/soramitsu/iroha2/client/Iroha2Client.kt
Outdated
Show resolved
Hide resolved
Mingela
reviewed
Jul 14, 2023
modules/client/src/main/kotlin/jp/co/soramitsu/iroha2/client/Iroha2Client.kt
Outdated
Show resolved
Hide resolved
Mingela
reviewed
Jul 14, 2023
modules/client/src/main/kotlin/jp/co/soramitsu/iroha2/client/Iroha2Client.kt
Outdated
Show resolved
Hide resolved
|
I'd also prefer some separate advanced structure for the subscription, imagine we will expect more stuff in blocks over time and need to process the specific ones separately and instead of spawning more subscriptions (not to load Iroha) I'd rather maintain a map of actions, i.e. <blockNumberFrom, action>, and make editing of a subscription possible (e.g. add action). Though I'm still thinking if that's convenient to use all actions combined in one altogether like it's implemented now. Opinions are welcome |
mversic
reviewed
Jul 19, 2023
modules/client/src/main/kotlin/jp/co/soramitsu/iroha2/transaction/TransactionBuilder.kt
Show resolved
Hide resolved
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Mingela
reviewed
Jul 26, 2023
modules/client/src/main/kotlin/jp/co/soramitsu/iroha2/SingletonHolder.kt
Show resolved
Hide resolved
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
mversic
requested changes
Aug 1, 2023
Mingela
approved these changes
Aug 1, 2023
mversic
approved these changes
Aug 2, 2023
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: Mingela <freekilluau@gmail.com>
Signed-off-by: akostiucenko <kostiuchenko@soramitsu.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.