Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on to the Configuration Overhaul RFC #8

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Oct 5, 2023

This PR introduces several aspects to the Configuration Overhaul RFC (#3) that were previously overlooked:

  • The presence of configuration endpoints
  • The existence of configuration-related Iroha Special Instructions (ISIs)
  • The potential extension of RFC proposals to other tools related to Iroha, specifically the Iroha Client CLI
  • The mechanism for resolving relative paths

For detailed insights, please refer to the PR's diff. These enhancements are part of the continued effort to refine and simplify Iroha's configuration process for a more intuitive and user-friendly experience.

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 0x009922 changed the title Add-on to Configuration Overhaul RFC Add-on to the Configuration Overhaul RFC Oct 5, 2023
@0x009922 0x009922 marked this pull request as ready for review October 5, 2023 07:51
001-config-overhaul.md Outdated Show resolved Hide resolved
001-config-overhaul.md Outdated Show resolved Hide resolved
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Copy link

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have no objections for On-Chain configuration part.

Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
@0x009922 0x009922 requested a review from Erigara October 26, 2023 04:39
@0x009922
Copy link
Contributor Author

Nah, don't really expect that there will be more feedback on that.

@0x009922 0x009922 closed this Oct 27, 2023
@0x009922 0x009922 reopened this Oct 27, 2023
@0x009922 0x009922 merged commit d348bcb into hyperledger-iroha:main Oct 27, 2023
1 check passed
@0x009922 0x009922 deleted the config-rfc-addon branch October 27, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants