Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep voting blocks #4643

Closed
mversic opened this issue May 24, 2024 · 0 comments · Fixed by #4828
Closed

Keep voting blocks #4643

mversic opened this issue May 24, 2024 · 0 comments · Fixed by #4828
Assignees
@dima74
Labels
Security This issue asks for improved security

Comments

@mversic
Copy link
Contributor

mversic commented May 24, 2024 •
edited by dima74
Loading

I have this issue in 4 places. It happens either on BlockSyncUpdate or BlockCreated. At the time of receiving a new block it's possible that the block is invalid and I would like to keep the old block while validating the new one. However, this creates deadlock as I have not released previous writer

Originally posted by @mversic in #4518 (comment)
@mversic mversic mentioned this issue May 27, 2024
Merged
5 tasks
@mversic mversic added the Security This issue asks for improved security label May 27, 2024
@dima74 dima74 self-assigned this Jul 8, 2024
@dima74 dima74 mentioned this issue Jul 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima74 dima74

Labels
Security This issue asks for improved security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Keep voting block if possible dima74/iroha
2 participants
@dima74 @mversic