Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: don't send public key with signature #4518

Merged
merged 3 commits into from
Jun 13, 2024
Merged

refactor!: don't send public key with signature #4518

merged 3 commits into from
Jun 13, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Apr 26, 2024 •
edited
Loading

Description

Linked issue

Closes #4393 #4410 #4264

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Apr 26, 2024
@mversic mversic force-pushed the remove_public_key branch 2 times, most recently from cee8760 to df420c1 Compare April 26, 2024 14:02
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Apr 26, 2024
@mversic mversic changed the title [refactor] #4393: don't send public key with signature (refactor): don't send public key with signature May 1, 2024
@mversic mversic changed the title (refactor): don't send public key with signature refactor!: don't send public key with signature May 1, 2024
@mversic mversic force-pushed the remove_public_key branch 2 times, most recently from dc4d7d7 to 3701fc5 Compare May 2, 2024 07:52
@mversic mversic removed the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 2, 2024
Erigara
Erigara suggested changes May 2, 2024
View reviewed changes
data_model/src/block.rs Outdated Show resolved Hide resolved
data_model/src/block.rs Outdated Show resolved Hide resolved
core/src/sumeragi/network_topology.rs Outdated Show resolved Hide resolved
core/src/block.rs Outdated Show resolved Hide resolved
@mversic mversic force-pushed the remove_public_key branch 5 times, most recently from bdb903e to fb852e9 Compare May 8, 2024 10:42
@mversic mversic force-pushed the remove_public_key branch 10 times, most recently from 857f74c to f2c9e56 Compare June 11, 2024 10:39
@mversic
refactor!: don't send public key with signature
b044546 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic
fix: view change updates
409f50e 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic force-pushed the remove_public_key branch 5 times, most recently from bc6341b to 9ab1290 Compare June 12, 2024 11:27
@mversic
refactor: remove public key from transaction and query
f72bfcc 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic requested review from s8sato and Erigara June 12, 2024 11:47
@mversic mversic enabled auto-merge (squash) June 12, 2024 20:52
@mversic mversic disabled auto-merge June 12, 2024 20:52
@mversic mversic enabled auto-merge (squash) June 13, 2024 08:04
@mversic mversic merged commit fbad993 into hyperledger-iroha:main Jun 13, 2024
10 of 11 checks passed
@mversic mversic deleted the remove_public_key branch June 13, 2024 10:06
@dima74 dima74 mentioned this pull request Jul 9, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato s8sato approved these changes

@Erigara Erigara Erigara approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@VAmuzing VAmuzing Awaiting requested review from VAmuzing

@Asem-Abdelhady Asem-Abdelhady Awaiting requested review from Asem-Abdelhady

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@Erigara Erigara

@mversic mversic

@s8sato s8sato

Labels
api-changes Changes in the API for client libraries Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we pack public keys with signatures?
3 participants
@mversic @Erigara @s8sato