-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3982: Clear live queries after smart contract end #4024
Merged
Arjentix
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Arjentix:live_query_end
Nov 20, 2023
Merged
[refactor] #3982: Clear live queries after smart contract end #4024
Arjentix
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Arjentix:live_query_end
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arjentix
added
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
Optimization
Something isn't working as well as it should
labels
Oct 30, 2023
Arjentix
requested review from
s8sato,
mversic,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
October 30, 2023 21:14
Pull Request Test Coverage Report for Build 6929164387
💛 - Coveralls |
mversic
reviewed
Oct 31, 2023
mversic
reviewed
Oct 31, 2023
mversic
reviewed
Oct 31, 2023
mversic
reviewed
Oct 31, 2023
I think tests is required here, we can postpone until client |
Erigara
reviewed
Oct 31, 2023
Arjentix
force-pushed
the
live_query_end
branch
3 times, most recently
from
November 2, 2023 22:24
655cc18
to
6f83160
Compare
Arjentix
force-pushed
the
live_query_end
branch
3 times, most recently
from
November 13, 2023 17:32
38be575
to
950a9de
Compare
Added test |
Arjentix
force-pushed
the
live_query_end
branch
from
November 13, 2023 19:50
950a9de
to
cca5ebd
Compare
Erigara
reviewed
Nov 14, 2023
Arjentix
force-pushed
the
live_query_end
branch
from
November 15, 2023 00:42
cca5ebd
to
5f8b710
Compare
mversic
previously approved these changes
Nov 16, 2023
mversic
reviewed
Nov 16, 2023
client/tests/integration/smartcontracts/executor_with_custom_token/src/lib.rs
Outdated
Show resolved
Hide resolved
mversic
reviewed
Nov 16, 2023
client/tests/integration/smartcontracts/query_assets_and_save_cursor/Cargo.toml
Show resolved
Hide resolved
mversic
reviewed
Nov 16, 2023
Arjentix
force-pushed
the
live_query_end
branch
from
November 16, 2023 14:43
5f8b710
to
12b37a2
Compare
Arjentix
force-pushed
the
live_query_end
branch
2 times, most recently
from
November 20, 2023 08:52
0ff9046
to
a916f01
Compare
mversic
previously approved these changes
Nov 20, 2023
mversic
reviewed
Nov 20, 2023
Arjentix
force-pushed
the
live_query_end
branch
from
November 20, 2023 08:57
a916f01
to
a03604a
Compare
mversic
approved these changes
Nov 20, 2023
Erigara
approved these changes
Nov 20, 2023
Arjentix
force-pushed
the
live_query_end
branch
from
November 20, 2023 10:44
a03604a
to
6108f9f
Compare
…tract end Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix
force-pushed
the
live_query_end
branch
from
November 20, 2023 11:03
6108f9f
to
914c440
Compare
mversic
approved these changes
Nov 20, 2023
DCNick3
pushed a commit
to DCNick3/iroha
that referenced
this pull request
Nov 22, 2023
…tract end (hyperledger-iroha#4024) Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Optimization
Something isn't working as well as it should
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LiveQueryStore
after wasm endQueryId
type aliasLinked issue
Closes #3982
Benefits
Checklist
CONTRIBUTING.md
unitintegration tests for the code changes