-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #4060: add support for boxed slices in FFI #4062
Merged
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:ffi_unsized_types
Nov 21, 2023
Merged
[feature] #4060: add support for boxed slices in FFI #4062
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
mversic:ffi_unsized_types
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
November 20, 2023 15:29
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Nov 20, 2023
Pull Request Test Coverage Report for Build 6942300741
💛 - Coveralls |
mversic
force-pushed
the
ffi_unsized_types
branch
from
November 20, 2023 15:49
b09eafe
to
f6dfc2c
Compare
DCNick3
reviewed
Nov 21, 2023
mversic
force-pushed
the
ffi_unsized_types
branch
from
November 21, 2023 09:27
f6dfc2c
to
7be144e
Compare
DCNick3
previously approved these changes
Nov 21, 2023
Erigara
reviewed
Nov 21, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
ffi_unsized_types
branch
from
November 21, 2023 10:15
7be144e
to
21df8c3
Compare
DCNick3
approved these changes
Nov 21, 2023
Erigara
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #4060
Benefits
Checklist
CONTRIBUTING.md