feat!: generalize permissions schema to executor data model #4658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
DCNick3,
VAmuzing and
dima74
as code owners
5 tasks
mversic
reviewed
May 28, 2024
mversic
requested changes
May 28, 2024
client/tests/integration/smartcontracts/executor_remove_permission/src/lib.rs
Outdated
Show resolved
Hide resolved
client/tests/integration/smartcontracts/executor_with_custom_permission/src/lib.rs
Outdated
Show resolved
Hide resolved
mversic
reviewed
May 28, 2024
mversic
reviewed
May 28, 2024
dima74
reviewed
May 28, 2024
0x009922
force-pushed
the
executor-data-model
branch
from
9d2d4a8 to
626c476
Compare
0x009922
commented
May 29, 2024
mversic
reviewed
May 29, 2024
mversic
reviewed
May 29, 2024
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922
force-pushed
the
executor-data-model
branch
from
626c476 to
a541b71
Compare
mversic
previously approved these changes
May 29, 2024
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
mversic
previously approved these changes
May 29, 2024
dima74
previously approved these changes
May 29, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
approved these changes
May 29, 2024
dima74
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a version of #4597, but without changing anything about parameters. What to do with parameters is not yet clear.
Benefits
Gives a foundation for executor-defined...
Linked issue
None