Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(torii): display more error details #4973

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix(torii): display more error details #4973

merged 1 commit into from
Aug 21, 2024

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Aug 14, 2024 •
edited
Loading

Description

While submitting an invalid transaction to Iroha, I got a response 400 Bad Request with message

Failed to accept transaction

That was not very helpful. This PR extends this message:

Failed to accept transaction

Caused by:
    Chain id doesn't correspond to the id of current blockchain: Expected ChainId("00000000-0000-0000-0000-000000000000"), actual ChainId("0")

Iroha has detailed errors internally, but their formatting doesn't work properly.

This PR does not aim to fix the issue entirely, but only highlights & fixes a special case of it. The main issue is #4974

Linked issue

Related to #4974

Benefits

Better error messages at least on the highest level of Torii.

@0x009922 0x009922 added Enhancement New feature or request UI Something about the interface labels Aug 14, 2024
@0x009922 0x009922 self-assigned this Aug 14, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Aug 14, 2024
@0x009922 0x009922 mentioned this pull request Aug 14, 2024
Open
@mversic mversic force-pushed the fix/slightly-better-torii-errors branch from 740f962 to 4eb68f9 Compare August 19, 2024 12:53
@0x009922 0x009922 mentioned this pull request Aug 21, 2024
Open
3 tasks
@nxsaken nxsaken force-pushed the fix/slightly-better-torii-errors branch from 4eb68f9 to 6c49433 Compare August 21, 2024 08:48
@0x009922 @nxsaken
fix(torii): display more error details
3aa60e2 
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@nxsaken nxsaken force-pushed the fix/slightly-better-torii-errors branch from 6c49433 to 3aa60e2 Compare August 21, 2024 10:03
@nxsaken nxsaken merged commit 2d4121f into hyperledger-iroha:main Aug 21, 2024
9 of 11 checks passed
@0x009922 0x009922 deleted the fix/slightly-better-torii-errors branch August 23, 2024 06:43
mversic pushed a commit that referenced this pull request Aug 30, 2024
@0x009922 @mversic
fix(torii): display more error details (#4973)
04e6bc4 
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@nxsaken nxsaken

@0x009922 0x009922

@mversic mversic

Labels
api-changes Changes in the API for client libraries Enhancement New feature or request UI Something about the interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0x009922 @nxsaken @mversic