-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-model)!: more consistent query parameters #4978
fix(data-model)!: more consistent query parameters #4978
Conversation
that is the hard upper limit, we can choose to make it tighter. Using a |
I am fine either way, just want to make it consistent.
I see, maybe then make it even smaller, like |
1fdf568
to
7c31e5a
Compare
@mversic as was discussed, let's keep |
e9c5c73
to
f158aba
Compare
Tests seem to work on my machine. |
f158aba
to
c0085d1
Compare
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
c0085d1
to
a365519
Compare
Context
There are some minor inconsistencies within query parameters (pagination, fetch size, sorting):
iroha_data_model
as a libraryu32
, while pagination offset isu64
. It doesn't make sense, since they are all technically limited to the maximum vec size in Iroha, which isusize
, which is commonly represented asu64
in the data model.Option<NonZero<u64>>
, whereNone
value doesn't give any additional meaning and is just treated as zero, which is also a default value foru64
.Solution
u64
/NonZero<u64>
everywhereu64
instead ofOption<NonZero<u64>>
offset
, second islimit
(affects ordering in the constructor)Review notes (optional)
Checklist
CONTRIBUTING.md
.