修复blockhash生成问题 #136
Closed
修复blockhash生成问题 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daring5920
requested review from
JeevaSang,
nekia,
nfrunza,
vchinoy-da and
xspeedcruiser
as code owners
nekia
reviewed
Jul 11, 2020
| this.key('PreviousHash').octstr(), | ||
| this.key('DataHash').octstr() | ||
| ); | ||
| }); | ||
| logger.info('generateBlockHash', header.number.toString()); | ||
| const output = headerAsn.encode( | ||
| { | ||
| Number: header.number.toString(), | ||
| Number: parseInt(header.number), |
There was a problem hiding this comment.
Based on your patch, I did some changes in my local. With the following patch, current block hash of each block gets identical with the previous hash of the next block. Your thought?
diff --git a/app/platform/fabric/utils/FabricUtils.js b/app/platform/fabric/utils/FabricUtils.js
index 664e115..e7e7f94 100644
--- a/app/platform/fabric/utils/FabricUtils.js
+++ b/app/platform/fabric/utils/FabricUtils.js
@@ -134,7 +134,7 @@ async function generateDir() {
async function generateBlockHash(header) {
const headerAsn = asn.define('headerAsn', function() {
this.seq().obj(
- this.key('Number').octstr(),
+ this.key('Number').int(),
this.key('PreviousHash').octstr(),
this.key('DataHash').octstr()
);
@@ -142,9 +142,9 @@ async function generateBlockHash(header) {
logger.info('generateBlockHash', header.number.toString());
const output = headerAsn.encode(
{
- Number: header.number.toString(),
- PreviousHash: header.previous_hash.toString('hex'),
- DataHash: header.data_hash.toString('hex')
+ Number: parseInt(header.number.low),
+ PreviousHash: header.previous_hash,
+ DataHash: header.data_hash
},
'der'
);
nekia
reviewed
Jul 11, 2020
| {clientJson.version} | ||
|   | ||
| {'Fabric Compatibility: '} {Version.map(v => v)} | ||
| {'Deaking Compatibility: '} {Version.map(v => v)} | ||
| </div> |
There was a problem hiding this comment.
Is this change included by mistake?
nekia
suggested changes
Jul 11, 2020
|
The following steps will be help for you to fix the error in DCO check. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.