Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE-814 Fix inconsistency of network key #172

Merged
merged 1 commit into from
Aug 24, 2020
Merged

BE-814 Fix inconsistency of network key #172

merged 1 commit into from
Aug 24, 2020

Conversation

nekia
Copy link
Contributor

@nekia nekia commented Aug 23, 2020 •
edited
Loading

Fixed to use only network ID for managing state internally (network Name is used only for showing network name on Login view)

app/platform/fabric/config.json
{
	"network-configs": {
		"first-network": {  <===[Network-ID]
			"name": "My first network",   <===[Network-Name]
			"profile": "./connection-profile/first-network.json"
		}
	},
	"license": "Apache-2.0"
}

The name in a connection profile is not used any purpose.

app/platform/fabric/connection-profile/first-network.json
{
	"name": "first network (ignored)",   <===[NotUsed]
	"version": "1.0.0",
	"license": "Apache-2.0",
	"client": {
		"tlsEnable": true,

Signed-off-by: Atsushi Neki atsushin@fast.au.fujitsu.com

@nekia
BE-814 Fix inconsistency of network key
73755a9 
Unified to use only network ID (network Name is used only for showing
network name on Login view)

Signed-off-by: Atsushi Neki <atsushin@fast.au.fujitsu.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JeevaSang
JeevaSang approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@JeevaSang JeevaSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@JeevaSang JeevaSang merged commit b020de2 into hyperledger-labs:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaSang JeevaSang JeevaSang approved these changes

@nfrunza nfrunza Awaiting requested review from nfrunza

@vchinoy-da vchinoy-da Awaiting requested review from vchinoy-da

@xspeedcruiser xspeedcruiser Awaiting requested review from xspeedcruiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekia @JeevaSang