Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be 769 convert to ts #184

Merged
merged 12 commits into from
Sep 26, 2020
Merged

Be 769 convert to ts #184

merged 12 commits into from
Sep 26, 2020

Conversation

JeevaSang
Copy link
Contributor

BE-769 Converted to Typescript all common files

JeevaSang added 10 commits June 8, 2020 18:55
@JeevaSang
Merge pull request #2 from hyperledger/master
9cddebc 
BE-750 Implement queryInstantiatedChaincodes by using "getchaincodes"…
@JeevaSang
Merge branch 'master' of https://github.com/hyperledger/blockchain-ex…
491099f 
…plorer
@JeevaSang
Merge branch 'master' of https://github.com/hyperledger/blockchain-ex…
5dd0c85 
…plorer
@JeevaSang
Merge branch 'master' of https://github.com/hyperledger/blockchain-ex…
61ecebb 
…plorer
@JeevaSang
Merge branch 'master' of https://github.com/hyperledger/blockchain-ex…
8526088 
…plorer
@JeevaSang
BE-824 Converted javascript to typescript
6914190 
Signed-off-by: jeeva <jeevasang@gmail.com>
@JeevaSang
BE-769 Converted Javascript to Typescript
405bce9 
Signed-off-by: jeeva <jeevasang@gmail.com>
@JeevaSang
Merge branch 'BE-824-convert-ts' of https://github.com/JeevaSang/bloc…
c86c44d 
…kchain-explorer into JeevaSang-BE-824-convert-ts
@JeevaSang
BE-769 Converted to Typescript all common files
0f59384 
Signed-off-by: jeeva <jeevasang@gmail.com>
@JeevaSang
Removed eslint
93d008a 
Signed-off-by: jeeva <jeevasang@gmail.com>
nekia
nekia suggested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@nekia nekia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left a request. Please take a look at it.

package.json Outdated Show resolved Hide resolved
@JeevaSang
moved to devDependencies
b1045ba 
Signed-off-by: jeeva <jeevasang@gmail.com>
@JeevaSang JeevaSang requested a review from nekia September 24, 2020 14:06
@JeevaSang
Moved to devDependencies
aa73da0 
Signed-off-by: jeeva <jeevasang@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nekia
nekia suggested changes Sep 25, 2020
View reviewed changes
package.json Show resolved Hide resolved
sync.js Show resolved Hide resolved
@nekia
Copy link
Contributor

nekia commented Sep 25, 2020

Thanks @JeevaSang
I left another comments.

@nekia nekia merged commit 65b5001 into hyperledger-labs:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekia nekia nekia approved these changes

@nfrunza nfrunza Awaiting requested review from nfrunza

@vchinoy-da vchinoy-da Awaiting requested review from vchinoy-da

@xspeedcruiser xspeedcruiser Awaiting requested review from xspeedcruiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeevaSang @nekia