Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE-834 Fix memory leak issue of sync process #206

Merged
merged 3 commits into from
Dec 11, 2020
Merged

BE-834 Fix memory leak issue of sync process #206

merged 3 commits into from
Dec 11, 2020

Conversation

nekia
Copy link
Contributor

@nekia nekia commented Dec 11, 2020

https://jira.hyperledger.org/browse/BE-834

Also recreated a new unit test suite for server backend (FabricGateway.ts)
We can run the unit test with the following:

cd blockchain-explorer
npm install
npm run test
  • This is the work item for BE-837

nekia added 3 commits December 10, 2020 23:48
@nekia
BE-834 Fix memory leak issue in the setup of DS
4201d71 
Changed to keep a discovery service instance after initializing it at
the boot phase.

Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
@nekia
BE-834 Add unit test for the fix of memory leak issue
affddef 
Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
@nekia
Add code coverage for unit test
2835570 
Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
@nekia nekia changed the title BE-834 memory leak BE-834 Fix memory leak issue of sync process Dec 11, 2020
@nekia nekia force-pushed the be-834-memory-leak branch from e4d191d to 2835570 Compare December 11, 2020 11:38
@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JeevaSang
JeevaSang approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@JeevaSang JeevaSang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thank you!

@JeevaSang JeevaSang merged commit ed36c28 into hyperledger-labs:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaSang JeevaSang JeevaSang approved these changes

@nfrunza nfrunza Awaiting requested review from nfrunza

@vchinoy-da vchinoy-da Awaiting requested review from vchinoy-da

@xspeedcruiser xspeedcruiser Awaiting requested review from xspeedcruiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nekia @JeevaSang