BE-852 Fix to get RWset for config TX synced correctly #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nekia
commented
Jan 25, 2021
nekia
commented
- Also added computation of ID for config TX to serve as a reference for the API & frontend. (Normally config tx doesn't have its tx id).
- Added test cases for processBlockEvent method in SyncServices class.
Also added computation of ID for config TX Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
Mainly added test cases for processBlockEvent method. Signed-off-by: Atsushi Neki <nekiaiken@gmail.com>
nekia
requested review from
JeevaSang,
nfrunza,
vchinoy-da and
xspeedcruiser
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.