Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: trailing ampersand sign that is preventing container from restarting #254

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Bugfix: trailing ampersand sign that is preventing container from restarting #254

merged 1 commit into from
Jul 1, 2021

Conversation

ThomasRalee
Copy link
Contributor

This PR:

  • removes trailing ampersand sign in start script which prevents docker container from restarting.

Note: this has been reflected with @nekia, more info here.

@ThomasRalee
Bugfix: tailing ampersand sign prevents container from restarting
2f6a173 
Signed-off-by: Thomas <thomas.leera@gmail.com>
@ThomasRalee ThomasRalee changed the title Bugfix: tailing ampersand sign prevents container from restarting Bugfix: trailing ampersand sign prevents container from restarting Jul 1, 2021
@ThomasRalee ThomasRalee changed the title Bugfix: trailing ampersand sign prevents container from restarting Bugfix: trailing ampersand sign that is preventing container from restarting Jul 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

nekia
nekia approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@nekia nekia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nekia nekia merged commit fef5460 into hyperledger-labs:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekia nekia nekia approved these changes

@JeevaSang JeevaSang Awaiting requested review from JeevaSang

@nfrunza nfrunza Awaiting requested review from nfrunza

@vchinoy-da vchinoy-da Awaiting requested review from vchinoy-da

@xspeedcruiser xspeedcruiser Awaiting requested review from xspeedcruiser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasRalee @nekia