Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github ci #339

Merged
merged 3 commits into from
Aug 22, 2023
Merged

added github ci #339

merged 3 commits into from
Aug 22, 2023

Conversation

adityajoshi12
Copy link
Contributor

Signed-off-by: Aditya Joshi adityaprakashjoshi1@gmail.com

What this PR does / why we need it:

This PR has changes for adding github actions as CI. This will ensure the build and test are running fine.

Which issue(s) this PR fixes:

Fixes #329

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation, usage docs, etc.:


@adityajoshi12 adityajoshi12 requested a review from a team as a code owner January 27, 2023 07:05
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>


- name: build client
run: CI=false npm run build --prefix client #warnning are considered as failed build, skipping warnings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replicate the existing CI setup for the purposes of release? Let's pick up the tasks to fix warnings if need be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CI is to run the build and test.

[![CII Best Practice](https://bestpractices.coreinfrastructure.org/projects/2710/badge)](https://bestpractices.coreinfrastructure.org/projects/2710)
[![Documentation Status](https://readthedocs.org/projects/blockchain-explorer/badge/?version=main)](https://blockchain-explorer.readthedocs.io/en/main/?badge=main)
[![Language grade: JavaScript](https://img.shields.io/lgtm/grade/javascript/g/hyperledger/blockchain-explorer.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/hyperledger/blockchain-explorer/context:javascript)
[![Total alerts](https://img.shields.io/lgtm/alerts/g/hyperledger/blockchain-explorer.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/hyperledger/blockchain-explorer/alerts/)
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=hyperledger_blockchain-explorer&metric=alert_status)](https://sonarcloud.io/dashboard?id=hyperledger_blockchain-explorer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryjones is there a possibility for us to continue using this sonar setup?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out #419

@ryjones ryjones merged commit 7a7f421 into hyperledger-labs:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CI to GitHub Actions
4 participants