added github ci #339
Merged
added github ci #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineethboppudi
approved these changes
Mar 24, 2023
adityajoshi12
force-pushed
the
main
branch
2 times, most recently
from
268240c
to
99d7a38
Compare
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
arsulegai
reviewed
Jul 6, 2023
|
|
||
|
|
||
| - name: build client | ||
| run: CI=false npm run build --prefix client #warnning are considered as failed build, skipping warnings |
There was a problem hiding this comment.
Can we replicate the existing CI setup for the purposes of release? Let's pick up the tasks to fix warnings if need be.
There was a problem hiding this comment.
This CI is to run the build and test.
| [](https://bestpractices.coreinfrastructure.org/projects/2710) | ||
| [](https://blockchain-explorer.readthedocs.io/en/main/?badge=main) | ||
| [](https://lgtm.com/projects/g/hyperledger/blockchain-explorer/context:javascript) | ||
| [](https://lgtm.com/projects/g/hyperledger/blockchain-explorer/alerts/) | ||
| [](https://sonarcloud.io/dashboard?id=hyperledger_blockchain-explorer) |
There was a problem hiding this comment.
@ryjones is there a possibility for us to continue using this sonar setup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya Joshi adityaprakashjoshi1@gmail.com
What this PR does / why we need it:
This PR has changes for adding github actions as CI. This will ensure the build and test are running fine.
Which issue(s) this PR fixes:
Fixes #329
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: