move to ghcr registry #382
Conversation
|
@vineeth2328 please look into this PR. |
@ArchanaArige please add me to the reviewers list |
adityajoshi12
force-pushed
the
docker-ci
branch
from
7641e92 to
02dd28e
Compare
.github/workflows/release.yaml
Outdated
| context: . | ||
| file: ./postgres-Dockerfile | ||
| push: true | ||
| platforms: linux/amd64,linux/arm64,linux/arm/v7 |
There was a problem hiding this comment.
I tried to run release.yaml pipeline and encountered with the below issue.
Can you please look into this issue
There was a problem hiding this comment.
removed the linux/arm/v7 builds
ArchanaArige
requested review from
arsulegai
and removed request for
vineethboppudi
.github/workflows/release.yaml
Outdated
| file: ./Dockerfile | ||
| push: true | ||
| platforms: linux/amd64,linux/arm64 | ||
| tags: ${{ steps.image_path_format.outputs.lowercase }}/explorer:${{ steps.vars.outputs.tag }} |
There was a problem hiding this comment.
Q: Can you please check the auto-version increment step as well?
There was a problem hiding this comment.
version is based on release tag, anytime a release tag is created, the same will be used as version.
There was a problem hiding this comment.
Please dont merge this PR as there is a dependency on of the test-case(failing).
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Hi @adityajoshi12 , As per yesterdays (23Aug2023) discussion on this PR, the image build should be triggered only whenever a new release happens(build-and-push-docker-release).
Please look into this and make changes accordingly. Thanks.
There was a problem hiding this comment.
There are two flow in this CI, one is(L62) when anything pushed to the main branch container images will be created with the latest tag, while the other flow(L84) will be invoked on the creation of tags and new container images will be created based on the tag
There was a problem hiding this comment.
yes, as per the first workflow the image gets created whenever the code is pushed to main branch. As per discussion conclusion yesterday, the build image should happen whenever we create a new release.
There was a problem hiding this comment.
okay, I understood that, but does that mean we will not have images with latest tag.
There was a problem hiding this comment.
I think we can run the two workflows. With the first workflow, we would have the images with the latest tag and with the second work flow will have the images with the release tag. However the first - workflow shouldn't be triggered on every push to main. @adityajoshi12 @arsulegai @vineeth2328 Please suggest.
There was a problem hiding this comment.
We can have a seperate branch dev and all the new commit/PR can be merged to that branch (dev) and after sometime we can merge the dev branch to the main branch. And image with tag latest can be build with main branch
There was a problem hiding this comment.
I agree @ArchanaArige , for the time being, let us have a human triggered workflow for the latest tag image creation. Re: Branching strategy, Manoj (mentee) is experimenting something similar and listing down advantages/disadvantages in terms of maintainability.
There was a problem hiding this comment.
Will discuss about this one in the next call and make a decision. There are some other dependency PRs, once they are merged, then we can go ahead and merge this one too.
adityajoshi12
force-pushed
the
docker-ci
branch
3 times, most recently
from
192531d to
078f722
Compare
Signed-off-by: Aditya Joshi <adityaprakashjoshi1@gmail.com>
adityajoshi12
force-pushed
the
docker-ci
branch
from
078f722 to
0bc5fe9
Compare
|
Tested the PR with the new changes in the forked repo.
|
|
This is the expected behavior. The images will be created for release tags only. There is a check that looks for the tag and skips the workflow, if the tag is not present. |
ok. Thanks a lot @adityajoshi12. |
What this PR does / why we need it:
This PR will start using ghcr.io as the container registry. This will create the
explorerandexplorer-dbcontainer image.Which issue(s) this PR fixes:
Fixes #348
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: