Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE-433 | Fix package related breaking issues #434

Merged
merged 1 commit into from
Aug 29, 2023
Merged

BE-433 | Fix package related breaking issues #434

merged 1 commit into from
Aug 29, 2023

Conversation

deekshithvarma256
Copy link
Contributor

What this PR does / why we need it:

Fixes the following issues related to package.json old packages.

  • For Node versions 14 and 16, the explorer keeps exiting without any error in the logs or console.
  • The docker image build for node v16 fails because of npm dependencies.
  • Testcase error because of old ts-node version.

Which issue(s) this PR fixes:

Fixes #433

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation, usage docs, etc.:

@deekshithvarma256
BE-433 | Fix package related breaking issues
bc08a91 
Signed-off-by: deekshithvarma256 <deekshithvarma256@gmail.com>
@deekshithvarma256 deekshithvarma256 requested a review from a team as a code owner August 29, 2023 08:22
ArchanaArige
ArchanaArige approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@ArchanaArige ArchanaArige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine.

@ArchanaArige ArchanaArige merged commit 7063492 into hyperledger-labs:main Aug 29, 2023
6 checks passed
@satoshinakamoto007
Copy link

What this PR does / why we need it:

Fixes the following issues related to package.json old packages.

  • For Node versions 14 and 16, the explorer keeps exiting without any error in the logs or console.

  • The docker image build for node v16 fails because of npm dependencies.

  • Testcase error because of old ts-node version.

Which issue(s) this PR fixes:

Fixes #433

Special notes for your reviewer:

Does this PR introduce a user-facing change?


NONE

Additional documentation, usage docs, etc.:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArchanaArige ArchanaArige ArchanaArige approved these changes

Assignees

@deekshithvarma256 deekshithvarma256

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 14, 16 silent exit and docker image fail for node 16
3 participants
@deekshithvarma256 @satoshinakamoto007 @ArchanaArige