Merge pull request #710 from boschresearch/fix/v2credentials-not-disp…

…layed-in-wallet fix v2 credentials not being shown in wallet
hyperledger-labs · Feb 4, 2022 · a2f9659 · a2f9659
2 parents 26dfe2f + 5d4d458
commit a2f9659
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -137,7 +137,7 @@ jobs:
         if: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') }}
         with:
           context: .
-          platforms: linux/amd64,linux/arm64
+          platforms: linux/amd64
           push: true
           file: Dockerfile.run
           tags: ${{ steps.preparetags.outputs.tags }}
diff --git a/...gent/src/main/java/org/hyperledger/bpa/impl/aries/credential/IssuerCredentialManager.java b/...gent/src/main/java/org/hyperledger/bpa/impl/aries/credential/IssuerCredentialManager.java
@@ -556,12 +556,15 @@ public void handleIssueCredentialV2Indy(V2IssueIndyCredentialEvent revocationInf
                         revocationInfo.getCredRevId());
             } else if (bpaEx.roleIsHolder() && StringUtils.isNotEmpty(revocationInfo.getCredIdStored())) {
                 credExRepo.updateReferent(bpaEx.getId(), revocationInfo.getCredIdStored());
-                // holder event is missing the credRevId
-                try {
-                    ac.credential(revocationInfo.getCredIdStored()).ifPresent(
-                            c -> credExRepo.updateRevocationInfo(bpaEx.getId(), c.getRevRegId(), c.getCredRevId()));
-                } catch (IOException e) {
-                    log.error(msg.getMessage("acapy.unavailable"));
+                // holder event is missing the credRevId, so get it from aca-py in case the
+                // credential is revocable
+                if (StringUtils.isNotEmpty(revocationInfo.getRevRegId())) {
+                    try {
+                        ac.credential(revocationInfo.getCredIdStored()).ifPresent(
+                                c -> credExRepo.updateRevocationInfo(bpaEx.getId(), c.getRevRegId(), c.getCredRevId()));
+                    } catch (IOException e) {
+                        log.error(msg.getMessage("acapy.unavailable"));
+                    }
                 }
             }
         });

diff --git a/frontend/src/components/MyCredentialList.vue b/frontend/src/components/MyCredentialList.vue
@@ -172,7 +172,9 @@ export default {
               type === "credential"
                 ? result.data.filter((item) => {
                     return (
-                      item.state === CredentialExchangeStates.CREDENTIAL_ACKED
+                      item.state ===
+                        CredentialExchangeStates.CREDENTIAL_ACKED ||
+                      item.state === CredentialExchangeStates.DONE
                     );
                   })
                 : result.data;