-
Notifications
You must be signed in to change notification settings - Fork 49
Customized UX #477
Customized UX #477
Conversation
…k and feel as current BPA.
e5c651c
to
a339ee1
Compare
Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
a339ee1
to
c414fa1
Compare
…xt properly in a later PR. Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
I will do another PR that touches up the buttons to make them more consistent. We have design standards that have Primary buttons solid color and secondary are text/outlined. I notice that we have forms and dialogs that have only secondary buttons, so I want to update some of those to Primary. I didn't want that in this PR because it will alter a lot of .vue files, so thought it would be best to break it up in case we don't like it. |
cool stuff ! :-) |
@@ -0,0 +1,56 @@ | |||
bpa: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's not a good practice to add config files that are specific to an organization to the resources folder. Instead I would propose to reference or generate this in the helm chart and then overwrite the settings in application.yml with -Dmicronaut.config.files=classpath:application.yml,/home/indy/bcgov-ux.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. That was from when I started out. I have removed that file. I am using the bcgov overrides as a commented out example so new developers can see what is possible/allowed.
frontend/src/App.vue
Outdated
Object.assign(this.ux, this.$config.ux); | ||
|
||
// Copy the the configuration UX themes, this allows us to change primary color later... | ||
if (this.ux.theme.override) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the override property needed? So you have the local defaults and as soon the web call responds with a section like ux.theme the local section is meant to be written anyway. So long story short shouldn't if(this.ux.theme)
have the same effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated to remove the override
properties and just use the parent property as suggested.
…de, remove the bcgov-ux file. Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
Use configuration values to update the look and feel of the application.
Add in BC Gov branding (could be used by others), adjusts the UX to have a business logo on Top Right Hand side, can override the style of Title (add the BPA Name before page/screen title). Change the layout of the navigation (put logout at bottom, put Settings at bottom, hide About). Can override the favicon.
Colors are configurable and will set the vuetify light theme.
Will have a related PR for the helm charts to load ux like we do schemas for each deployment.
I have removed any changes to text via configuration. We had discussed that custom text changes should be handled when we do internationalization.
Also, note that the
main.js
the configuration is loaded synchronously before loadingApp.vue
, we need the configuration data to be fully loaded first.BCGov Branded (loaded to Openshift via Helm charts)
Default branding (loaded to Openshift via Helm charts)