Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Customized UX #477

Merged
merged 4 commits into from
Jun 16, 2021
Merged

Conversation

usingtechnology
Copy link
Contributor

@usingtechnology usingtechnology commented Jun 14, 2021

Use configuration values to update the look and feel of the application.

Add in BC Gov branding (could be used by others), adjusts the UX to have a business logo on Top Right Hand side, can override the style of Title (add the BPA Name before page/screen title). Change the layout of the navigation (put logout at bottom, put Settings at bottom, hide About). Can override the favicon.

Colors are configurable and will set the vuetify light theme.

Will have a related PR for the helm charts to load ux like we do schemas for each deployment.

I have removed any changes to text via configuration. We had discussed that custom text changes should be handled when we do internationalization.

Also, note that the main.js the configuration is loaded synchronously before loading App.vue, we need the configuration data to be fully loaded first.

BCGov Branded (loaded to Openshift via Helm charts)

Screen Shot 2021-06-14 at 2 14 28 PM

Default branding (loaded to Openshift via Helm charts)

Screen Shot 2021-06-14 at 2 14 41 PM

Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
…xt properly in a later PR.

Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
@usingtechnology
Copy link
Contributor Author

I will do another PR that touches up the buttons to make them more consistent. We have design standards that have Primary buttons solid color and secondary are text/outlined. I notice that we have forms and dialogs that have only secondary buttons, so I want to update some of those to Primary. I didn't want that in this PR because it will alter a lot of .vue files, so thought it would be best to break it up in case we don't like it.

@usingtechnology usingtechnology marked this pull request as ready for review June 15, 2021 22:39
@frank-bee
Copy link
Contributor

cool stuff ! :-)

@@ -0,0 +1,56 @@
bpa:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a good practice to add config files that are specific to an organization to the resources folder. Instead I would propose to reference or generate this in the helm chart and then overwrite the settings in application.yml with -Dmicronaut.config.files=classpath:application.yml,/home/indy/bcgov-ux.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. That was from when I started out. I have removed that file. I am using the bcgov overrides as a commented out example so new developers can see what is possible/allowed.

Object.assign(this.ux, this.$config.ux);

// Copy the the configuration UX themes, this allows us to change primary color later...
if (this.ux.theme.override) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the override property needed? So you have the local defaults and as soon the web call responds with a section like ux.theme the local section is meant to be written anyway. So long story short shouldn't if(this.ux.theme) have the same effect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to remove the override properties and just use the parent property as suggested.

…de, remove the bcgov-ux file.

Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
@usingtechnology usingtechnology merged commit 117a2f8 into hyperledger-labs:master Jun 16, 2021
@etschelp
Copy link
Contributor

@parc-jason In the default theme the settings section is now gone. I guess the default settings are not applied correctly because if I uncomment whats in the application.yml they show up again.

Screen Shot 2021-06-17 at 16 55 39

@usingtechnology
Copy link
Contributor Author

@parc-jason In the default theme the settings section is now gone. I guess the default settings are not applied correctly because if I uncomment whats in the application.yml they show up again.

Screen Shot 2021-06-17 at 16 55 39

I'll take a look and fix that. Good find!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants