Tags

[domwoe]

implements #491

• Configure (undeletable) tags for deployment under bpa.tags
• Tag Management (CRD) under Settings
• If a tag is assigned to at least one partner a dialog is shown to the user if she really wants to delete tag
• Add tag to partner while adding a partner or creating an invitation
• Update tags of partners in partner view (click on pencil)
• Show tags of partners in partner list

[domwoe]

I can't get the joins to work.

• Retrieving a partner with an associated tag won't retrieve the tag
• Retrieving a tag with an associated partner won't retrieve the partner

Tests yesterday worked because the model had the associated data, but after saving and retrieving the entity, the associated data is lost.

partner_tag association table gets populated. I've checked that manually.

I've set log level of micronaut.data.query to trace. But for some reason I don't see the INSERT statements to partner_tag there.

When you look at the query statements performed, there's no join:

08:45:12.769 [main] DEBUG query - Executing Query: SELECT partner_."id",partner_."created_at",partner_."updated_at",partner_."last_seen",partner_."did",partner_."aries_support",partner_."connection_id",partner_."state",partner_."label",partner_."alias",partner_."incoming",partner_."valid",partner_."verifiable_presentation",partner_."supported_credentials" FROM "partner" partner_ WHERE (partner_."id" = ?)

[gitpod-io]

[domwoe]

@etschelp What's your opinion on adding a tag to an invitation?

1. Add the tag as payload to POST: partners/invitation and handle it in the backend
2. Do a POST: .../invitation and a subsequent PUT: partner/:id or PUT: partner/:id/tag

First approach seems cleaner to me.

[lgtm-com]

This pull request introduces 1 alert when merging e9dfdd3 into 06da922 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 8872bd3 into 1a54916 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 31a5fb3 into 1a54916 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[etschelp]

I can't get the joins to work.

• Retrieving a partner with an associated tag won't retrieve the tag
• Retrieving a tag with an associated partner won't retrieve the partner

Tests yesterday worked because the model had the associated data, but after saving and retrieving the entity, the associated data is lost.

partner_tag association table gets populated. I've checked that manually.

I've set log level of micronaut.data.query to trace. But for some reason I don't see the INSERT statements to partner_tag there.

When you look at the query statements performed, there's no join:

08:45:12.769 [main] DEBUG query - Executing Query: SELECT partner_."id",partner_."created_at",partner_."updated_at",partner_."last_seen",partner_."did",partner_."aries_support",partner_."connection_id",partner_."state",partner_."label",partner_."alias",partner_."incoming",partner_."valid",partner_."verifiable_presentation",partner_."supported_credentials" FROM "partner" partner_ WHERE (partner_."id" = ?)

If you only want to tag during the invitation the first makes one makes sense. If you want to tag the partner separately as well then its easier doing it just on the partner level.

[lgtm-com]

This pull request introduces 1 alert when merging ab7a14b into 42960ad - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 2aa9fca into 42960ad - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging caf57c8 into 42960ad - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging af2240e into 42960ad - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging ffa7d87 into be86604 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 56532b4 into fc83ce1 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 2cc4816 into fc83ce1 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 3c9ac3f into fc83ce1 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 948ed48 into 85db25f - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 2e55da1 into 9a1c9b0 - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging 9e635f2 into 2a1356b - view on LGTM.com

new alerts:

• 1 for Overwritten property

[lgtm-com]

This pull request introduces 1 alert when merging c562f50 into ee1621b - view on LGTM.com

new alerts:

• 1 for Overwritten property