This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Use did exchange protocol for all connections #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com> # Conflicts: # backend/business-partner-agent/src/main/java/org/hyperledger/bpa/impl/mode/web/WebDidDocManager.java
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
domwoe
reviewed
Jul 8, 2021
| @@ -74,11 +70,12 @@ export const getPartnerState = (partner) => { | |||
| export const getPartnerStateColor = (state) => { | |||
| if (state === PartnerStates.REQUEST.value) { | |||
| return "yellow"; | |||
| } else if (state === PartnerStates.INACTIVE.value) { | |||
| } else if (state === PartnerStates.ABANDONED.value) { | |||
There was a problem hiding this comment.
@etschelp Do you normalize this in the backend? I'm asking because Partners/Connections based on explicit QR Code invitations will still be using the RFC160 Connection Protocol since smartphone wallets have not yet implemented DID Exchange.
There was a problem hiding this comment.
Ah, inactive was something we defined anyways...
…stead of alias Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
etschelp
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched all connection related methods to did exchange. Like this it is possible to send the agents public did with the connection request. The opposite BPA now resolves the public profile if it finds a public did in the connection event. To use this functionality I also upgraded aca-py to 0.7-rc1. Also I fixed the partner naming strategy that the following order is used: alias, legal name, label. The alias is the value set by the user. The legal name is resolved from the public profile, the label is the label set by aca-py.