This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
Feature/proof request details styling #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Sy <jasyrotuck@gmail.com>
Signed-off-by: Jason Sy <jasyrotuck@gmail.com>
Signed-off-by: Jason Sy <jasyrotuck@gmail.com>
There was a problem hiding this comment.
Maybe change the ordering in PresentationRequestDetails.mount, start the credentials load first... give it a better chance of being completed before we show the ProofRequest component? Remove text attribute from BPAButtons and the submitDisabled property I can't find it anywhere.
| @@ -24,19 +24,19 @@ | |||
| <v-divider></v-divider> | |||
| </v-card-text> | |||
| <v-layout align-end justify-end> | |||
| <v-btn | |||
| <v-bpa-button | |||
| color="secondary" | |||
| text | |||
There was a problem hiding this comment.
BPAButtons don't add in the 'text' attribute, that will get picked up by the global ux config and handled by the BPAButton component.
| > | ||
| <v-btn | ||
| <v-bpa-button | ||
| :loading="this.isBusy" | ||
| color="primary" | ||
| text | ||
| @click="respondToPresentationRequest(presentationRequest)" | ||
| :disabled="submitDisabled" |
There was a problem hiding this comment.
I can't find where submitDisabled is set?
|
I think i've addressed both of these. |
Signed-off-by: Jason Sy <jasyrotuck@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't push all my local commits. this cleans up the FE a bit more.