Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Allow prod config #543

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Allow prod config #543

merged 1 commit into from
Jul 14, 2021

Conversation

frank-bee
Copy link
Contributor

@frank-bee frank-bee commented Jul 14, 2021

via -Dlog4j2.configurationFile=log4j2-prod.xml

Signed-off-by: frank-bee Frank.Bernhardt@bosch.com

via -Dlog4j2.configurationFile=log4j2-prod.xml

Signed-off-by: frank-bee <Frank.Bernhardt@bosch.com>
@frank-bee
Copy link
Contributor Author

Like this we could configure json appender via the helm chart if we need logging which is more logging framework friendly.
I could also configure it via special annotation at the pod with the follow downsides:

  • logging framework specific
  • depends on the configuration of the appender (if appender layout changes...)

@frank-bee
Copy link
Contributor Author

I merge this to be able to test it, but we can easily change it back...

@frank-bee frank-bee merged commit a2a6006 into hyperledger-labs:master Jul 14, 2021
@@ -4,9 +4,9 @@
<Property name="PATTERN">%d{HH:mm:ss.SSS} [%t] %-5level %c{1} - %replace{%msg}{[\r\n]+}{}%n</Property>
</Properties>
<Appenders>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appenders section is there for a reason. Mainly to configure more than one appender and then select one through sysprops. But I guess this works as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants