Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Virtual Partner Name/Alias #569

Merged

Conversation

etschelp
Copy link
Contributor

@etschelp etschelp commented Aug 11, 2021

Currently when we add a new Partner the Partners name is always pre filled with the partners legal name (if set). This can cause confusion because like this the partners alias is always set as well. For example:

  1. agent 1 adds a new partner with legal name foo
  2. partner changes legal name to bar
  3. agent 1 reloads partner, legal name changes to bar, display name stays foo

This is totally correct as this adheres to our partner name strategy, but it is very confusing to the user. So instead of using two way binding to set the alias I only set the placeholder like this,

Screen Shot 2021-08-11 at 16 34 47

then the user can set a real alias if needed.

Screen Shot 2021-08-11 at 16 34 56

Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
@etschelp etschelp changed the title Virtual Partner Alias Virtual Partner Name/Alias Aug 11, 2021
Signed-off-by: Philipp Etschel <philipp.etschel@ch.bosch.com>
@domwoe domwoe self-requested a review August 12, 2021 07:13
Copy link

@domwoe domwoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense! Good find!

@etschelp etschelp merged commit 5904bdd into hyperledger-labs:master Aug 12, 2021
@etschelp etschelp deleted the fix/alias-is-always-set branch August 12, 2021 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants