Feature/receive invite #585
Conversation
Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
* main: Set button loading during request Implement create and send button functionality Enable sending proof templates to the backend Add create proof template page + link router and buttons technical documentation via Sphinx and hosted by GitHub pages Prepare request presentation page for proof templates and pass through v-model from table Add optional checkboxes and search bar to proof templates list component Signed-off-by: Jason Sherman <jsherman@parcsystems.ca> # Conflicts: # frontend/src/plugins/vuetify.js
Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
usingtechnology
requested review from
etschelp and
domwoe
and removed request for
etschelp
| invitation.setOob(true); | ||
| // not supporting this until we can parse and send to aries client successfully | ||
| // coming very soon with next update of Aries Client Jar!!! | ||
| String msg = "Out of band Invitations are currently not supported"; |
There was a problem hiding this comment.
I have just released a new client 0.7.4 with the fix
There was a problem hiding this comment.
ok, I'll pull that in and add this functionality. Thanks for getting that done so quickly.
| partnerRepo.save(Partner | ||
| .builder() | ||
| .ariesSupport(Boolean.TRUE) | ||
| .alias(StringUtils.trimToNull(record.getTheirLabel())) |
There was a problem hiding this comment.
Alias should always be set by the user. In this case theirLabel should be label. See discussion about aliases, labels and fallbacks :)
There was a problem hiding this comment.
ok, so, should the UX have an alias field, defaulted to the label from the invitation? that make sense?
There was a problem hiding this comment.
basically, re-use the set tags/ping/alias code?
There was a problem hiding this comment.
when we generate the barcode for the invitation we have the UI below. In your case what about setting the placeholder to the label and if the user does not provide any input the backend can set the alias to the value of the label like you have it now?
There was a problem hiding this comment.
basically, re-use the set tags/ping/alias code?
yes same behavior
There was a problem hiding this comment.
perfect, will add that in, makes sense.
| .did(didPrefix + UNKNOWN_DID) | ||
| .state(ConnectionState.INVITATION) | ||
| .incoming(Boolean.TRUE) | ||
| .tags(null) |
There was a problem hiding this comment.
It would be cool if we could keep everything consistent. If we generate a partner invitation we also have the possibility to set an alias and tags.
There was a problem hiding this comment.
👍 see the above comments, will add that ux in.
| .state(ConnectionState.INVITATION) | ||
| .incoming(Boolean.TRUE) | ||
| .tags(null) | ||
| .trustPing(Boolean.FALSE) |
There was a problem hiding this comment.
Also selectable by the user everywhere else
add support for receiving out of band invitation update add partner from invitation screen to match add partner from did Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
Signed-off-by: Jason Sherman <jsherman@parcsystems.ca>
Update the Add Partner page to allow connect by DID and connect by Invitation Url.
This is to support connecting with non-phone Agents (ex. Trinsic Studio) that are only generating QR Codes and invitations. This allows us to take their generated invitation and create a Partner.
Currently tested and connected using our own invitations (connection and out of band) and an Invitation from Trinisic Studio.
I have added a simple single redirect handler when reading the invitation url. This is for implementations like Trinsic Studio, where they generate a short url (and thus a simpler easier to read qr code) that will take you to the real underlying invitation url (trinisic uses
d_mquery param, but results in a connection 1.0 invitation).Query Params for invitations
c_i(Aries RFC 0160: Connection Protocol)d_m(RFC 0268: Unified DIDCOMM Deeplinking)oob(Aries RFC 0434: Out-of-Band Protocol 1.1)